[pve-devel] [PATCH installer 2/3] proxinstall: set active element in combo box once

[Maximiliano Sandoval <m.sandoval@proxmox.com>]

We connect to the signal before setting the active device so it triggers.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 proxinstall | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/proxinstall b/proxinstall
index 1d22e22..cb74cc2 100755
--- a/proxinstall
+++ b/proxinstall
@@ -391,6 +391,8 @@ sub create_ipconf_view {
 	    if $iface->{inet}->{prefix} || $iface->{inet6}->{prefix};
     };
 
+    my $active_device_pos = 0;
+
     my $i = 0;
     for my $index (sort keys $ipconf->{ifaces}->%*) {
 	my $iface = $ipconf->{ifaces}->{$index};
@@ -403,20 +405,19 @@ sub create_ipconf_view {
 	$device_active_map->{$i} = $index;
 	$device_active_reverse_map->{$iface->{name}} = $i;
 	if ($ipconf_first_view && $index == $ipconf->{default}) {
-	    $device_cb->set_active($i);
-	    &$device_change_handler($device_cb);
+	    $active_device_pos = $i;
 	    $ipconf_first_view = 0;
 	}
 	$i++;
     }
-    $device_cb->signal_connect('changed' => $device_change_handler);
 
     if (my $nic = Proxmox::Install::Config::get_mngmt_nic()) {
-	$device_cb->set_active($device_active_reverse_map->{$nic} // 0);
-    } else {
-	$device_cb->set_active(0);
+	$active_device_pos = $device_active_reverse_map->{$nic};
     }
 
+    $device_cb->signal_connect('changed' => $device_change_handler);
+    $device_cb->set_active($active_device_pos);
+
     my $label = Gtk3::Label->new("Management Interface");
     $label->set_size_request(150, -1);
     $label->set_xalign(1.0);
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel