From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH installer 1/3] proxinstall: move device changed callback after loop
Date: Tue, 17 Dec 2024 16:23:14 +0100 [thread overview]
Message-ID: <20241217152316.381557-1-m.sandoval@proxmox.com> (raw)
Otherwise the callback will run once for each NIC.
Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
proxinstall | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/proxinstall b/proxinstall
index 8168529..1d22e22 100755
--- a/proxinstall
+++ b/proxinstall
@@ -407,9 +407,9 @@ sub create_ipconf_view {
&$device_change_handler($device_cb);
$ipconf_first_view = 0;
}
- $device_cb->signal_connect('changed' => $device_change_handler);
$i++;
}
+ $device_cb->signal_connect('changed' => $device_change_handler);
if (my $nic = Proxmox::Install::Config::get_mngmt_nic()) {
$device_cb->set_active($device_active_reverse_map->{$nic} // 0);
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2024-12-17 15:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-17 15:23 Maximiliano Sandoval [this message]
2024-12-17 15:23 ` [pve-devel] [PATCH installer 2/3] proxinstall: set active element in combo box once Maximiliano Sandoval
2024-12-17 15:23 ` [pve-devel] [PATCH installer 3/3] fix #2502: proxinstall: set cidr text manually Maximiliano Sandoval
2024-12-17 15:26 ` Maximiliano Sandoval
2025-01-30 14:00 ` Maximiliano Sandoval
2025-01-30 18:12 ` [pve-devel] applied-series: [PATCH installer 1/3] proxinstall: move device changed callback after loop Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241217152316.381557-1-m.sandoval@proxmox.com \
--to=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.