all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH installer] tree-wide: add workspace-level cargo package version
@ 2024-12-05 12:23 Christoph Heiss
  2025-01-28 14:31 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Christoph Heiss @ 2024-12-05 12:23 UTC (permalink / raw)
  To: pve-devel

Means that all CLIs will now have the correct version compiled-in.

This is at least very much relevant for
`proxmox-auto-install-assistant`, which we distribute separately as a
normal binary/package.

Currently, `proxmox-auto-install-assistant --version` always reports
'0.1.0', thus users have to effectively fall back to their system
package manager (if installed via such) to identify the correct version.

Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
---
Of course, that version now also needs to be bumped each time, in
addition to updating d/changelog -- much like it is done for
proxmox-backup.

Just noting it here for the sake of it.

 Cargo.toml                                | 3 +++
 proxmox-auto-install-assistant/Cargo.toml | 2 +-
 proxmox-auto-installer/Cargo.toml         | 2 +-
 proxmox-chroot/Cargo.toml                 | 2 +-
 proxmox-fetch-answer/Cargo.toml           | 2 +-
 proxmox-installer-common/Cargo.toml       | 2 +-
 proxmox-post-hook/Cargo.toml              | 2 +-
 proxmox-tui-installer/Cargo.toml          | 2 +-
 8 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/Cargo.toml b/Cargo.toml
index 8385d58..99b5425 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -10,6 +10,9 @@ members = [
     "proxmox-post-hook",
 ]
 
+[workspace.package]
+version = "8.3.4"
+
 [workspace.dependencies]
 anyhow = "1.0"
 log = "0.4.20"
diff --git a/proxmox-auto-install-assistant/Cargo.toml b/proxmox-auto-install-assistant/Cargo.toml
index 07e6ffb..c5d7b00 100644
--- a/proxmox-auto-install-assistant/Cargo.toml
+++ b/proxmox-auto-install-assistant/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "proxmox-auto-install-assistant"
-version = "0.1.0"
+version.workspace = true
 edition = "2021"
 authors = [
     "Aaron Lauterer <a.lauterer@proxmox.com>",
diff --git a/proxmox-auto-installer/Cargo.toml b/proxmox-auto-installer/Cargo.toml
index d06478f..8940b57 100644
--- a/proxmox-auto-installer/Cargo.toml
+++ b/proxmox-auto-installer/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "proxmox-auto-installer"
-version = "0.1.0"
+version.workspace = true
 edition = "2021"
 authors = [
     "Aaron Lauterer <a.lauterer@proxmox.com>",
diff --git a/proxmox-chroot/Cargo.toml b/proxmox-chroot/Cargo.toml
index 4a27bf7..eab945b 100644
--- a/proxmox-chroot/Cargo.toml
+++ b/proxmox-chroot/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "proxmox-chroot"
-version = "0.1.0"
+version.workspace = true
 edition = "2021"
 authors = [ "Aaron Lauterer <a.lauterer@proxmox.com>" ]
 license = "AGPL-3"
diff --git a/proxmox-fetch-answer/Cargo.toml b/proxmox-fetch-answer/Cargo.toml
index 23bd094..e610807 100644
--- a/proxmox-fetch-answer/Cargo.toml
+++ b/proxmox-fetch-answer/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "proxmox-fetch-answer"
-version = "0.1.0"
+version.workspace = true
 edition = "2021"
 authors = [
     "Aaron Lauterer <a.lauterer@proxmox.com>",
diff --git a/proxmox-installer-common/Cargo.toml b/proxmox-installer-common/Cargo.toml
index b97ccaf..80b3534 100644
--- a/proxmox-installer-common/Cargo.toml
+++ b/proxmox-installer-common/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "proxmox-installer-common"
-version = "0.1.0"
+version.workspace = true
 edition = "2021"
 authors = [ "Aaron Lauterer <a.lauterer@proxmox.com>" ]
 license = "AGPL-3"
diff --git a/proxmox-post-hook/Cargo.toml b/proxmox-post-hook/Cargo.toml
index a2ca206..acf7f9b 100644
--- a/proxmox-post-hook/Cargo.toml
+++ b/proxmox-post-hook/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "proxmox-post-hook"
-version = "0.1.0"
+version.workspace = true
 edition = "2021"
 authors = [
     "Christoph Heiss <c.heiss@proxmox.com>",
diff --git a/proxmox-tui-installer/Cargo.toml b/proxmox-tui-installer/Cargo.toml
index 3db7d73..1f04ce0 100644
--- a/proxmox-tui-installer/Cargo.toml
+++ b/proxmox-tui-installer/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "proxmox-tui-installer"
-version = "0.1.0"
+version.workspace = true
 edition = "2021"
 authors = [ "Christoph Heiss <c.heiss@proxmox.com>" ]
 license = "AGPL-3"
-- 
2.47.0



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pve-devel] applied: [PATCH installer] tree-wide: add workspace-level cargo package version
  2024-12-05 12:23 [pve-devel] [PATCH installer] tree-wide: add workspace-level cargo package version Christoph Heiss
@ 2025-01-28 14:31 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2025-01-28 14:31 UTC (permalink / raw)
  To: Proxmox VE development discussion, Christoph Heiss

Am 05.12.24 um 13:23 schrieb Christoph Heiss:
> Means that all CLIs will now have the correct version compiled-in.
> 
> This is at least very much relevant for
> `proxmox-auto-install-assistant`, which we distribute separately as a
> normal binary/package.
> 
> Currently, `proxmox-auto-install-assistant --version` always reports
> '0.1.0', thus users have to effectively fall back to their system
> package manager (if installed via such) to identify the correct version.
> 
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
> Of course, that version now also needs to be bumped each time, in
> addition to updating d/changelog -- much like it is done for
> proxmox-backup.
> 
> Just noting it here for the sake of it.
> 
>  Cargo.toml                                | 3 +++
>  proxmox-auto-install-assistant/Cargo.toml | 2 +-
>  proxmox-auto-installer/Cargo.toml         | 2 +-
>  proxmox-chroot/Cargo.toml                 | 2 +-
>  proxmox-fetch-answer/Cargo.toml           | 2 +-
>  proxmox-installer-common/Cargo.toml       | 2 +-
>  proxmox-post-hook/Cargo.toml              | 2 +-
>  proxmox-tui-installer/Cargo.toml          | 2 +-
>  8 files changed, 10 insertions(+), 7 deletions(-)
> 
>

applied, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-01-28 14:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-12-05 12:23 [pve-devel] [PATCH installer] tree-wide: add workspace-level cargo package version Christoph Heiss
2025-01-28 14:31 ` [pve-devel] applied: " Thomas Lamprecht

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal