Re: [pbs-devel] [PATCH proxmox-backup-restore-image] kernel: enable codepage 437 for vfat support

[Stoiko Ivanov <s.ivanov@proxmox.com>]

Thanks for the quick feedback!

On Tue, 26 Nov 2024 13:26:47 +0100
Fabian Grünbichler <f.gruenbichler@proxmox.com> wrote:

> adding missing subject prefix ;)
missed that part before sending a v2:
https://lore.proxmox.com/pbs-devel/20241126132602.576027-1-s.ivanov@proxmox.com/T/#u
(fixed now)

> 
> On November 26, 2024 1:03 pm, Stoiko Ivanov wrote:
> > ran into an issue when clicking on the ESP of a VM while trying
> > single-file restore.
> > 
> > the added config-config options are taken from config-6.5.13-6-pve
> > (the restore-image is still based on kernel 6.5) - and I tried copying
> > a small set around the needed options.  
> 
> maybe we should upgrade to a newer one at some point (might also benefit
> from NTFS bug fixes and added features..)
sounds sensible! - anyone got an idea how wide-spread EXFAT is (because it
is set in our regular-kernels (just after the VFAT-options))?
quick skim through the config for 6.11 did not yield anything else new that
seems too common (on guests).



> 
> > 
> > with the patch the ESP contents are shown successfully
> > 
> > Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> > ---
> >  src/config-base | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/src/config-base b/src/config-base
> > index 1581b09..238d93c 100644
> > --- a/src/config-base
> > +++ b/src/config-base
> > @@ -144,6 +144,11 @@ CONFIG_ISO9660_FS=y
> >  CONFIG_NTFS3_FS=y
> >  CONFIG_MSDOS_FS=y
> >  CONFIG_VFAT_FS=y
> > +CONFIG_FAT_DEFAULT_CODEPAGE=437
> > +CONFIG_FAT_DEFAULT_IOCHARSET="iso8859-1"  
> 
> these two are the default values anyway and already set without this
> patch?
yes - I sent the patch a bit too soon after my first test and before
taking the 2 minutes to look around the config file

> 
> > +CONFIG_NLS=y  
> 
> this one is set as well
> 
> > +CONFIG_NLS_DEFAULT="utf8"  
> 
> the upstream default for this is iso8859-1, but it also says this is
> "the NLS used by your console, not the NLS used by a specific file
> system (if different) to store data (filenames) on disk." - whatever
> that means exactly?
> 
> > +CONFIG_NLS_CODEPAGE_437=y  
> 
> shouldn't we also enable NLS_UTF8 ?
> 
> I mean, I guess it doesn't really matter as long as we don't start
> setting the corresponding mount options to force a specific codepage?
can't remember ever needing to set any code-page specific options for vfat
in quite a long time (and mounting various images for uncommon uses)
so I'd say - let's see if anyone runs into needing this.

> 
> the last option seems to be the only one that is actually missing from
> our config ;) althoug hit doesn't hurt to set any of the above
> explicitly I guess..
I think keeping this as minimal as needed makes sense, thus tested with
only `CONFIG_NLS_CODEPAGE_437=y` set - and decided to stick with that, as
it worked with a partition created with mkfs.vfat (the ESP from debian).



> 
> >  
> >  # memory hotplug
> >  CONFIG_MEMORY_HOTPLUG=y
> > -- 
> > 2.39.5
> > 
> > 
> > 
> > _______________________________________________
> > pbs-devel mailing list
> > pbs-devel@lists.proxmox.com
> > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> > 
> > 
> >   
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> 
> 



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel