[pbs-devel] [PATCH] kernel: enable codepage 437 for vfat support

[pbs-devel] [PATCH] kernel: enable codepage 437 for vfat support

[Stoiko Ivanov]

ran into an issue when clicking on the ESP of a VM while trying
single-file restore.

the added config-config options are taken from config-6.5.13-6-pve
(the restore-image is still based on kernel 6.5) - and I tried copying
a small set around the needed options.

with the patch the ESP contents are shown successfully

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
 src/config-base | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/config-base b/src/config-base
index 1581b09..238d93c 100644
--- a/src/config-base
+++ b/src/config-base
@@ -144,6 +144,11 @@ CONFIG_ISO9660_FS=y
 CONFIG_NTFS3_FS=y
 CONFIG_MSDOS_FS=y
 CONFIG_VFAT_FS=y
+CONFIG_FAT_DEFAULT_CODEPAGE=437
+CONFIG_FAT_DEFAULT_IOCHARSET="iso8859-1"
+CONFIG_NLS=y
+CONFIG_NLS_DEFAULT="utf8"
+CONFIG_NLS_CODEPAGE_437=y
 
 # memory hotplug
 CONFIG_MEMORY_HOTPLUG=y
-- 
2.39.5



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

Re: [pbs-devel] [PATCH proxmox-backup-restore-image] kernel: enable codepage 437 for vfat support

[Fabian Grünbichler]

adding missing subject prefix ;)

On November 26, 2024 1:03 pm, Stoiko Ivanov wrote:
> ran into an issue when clicking on the ESP of a VM while trying
> single-file restore.
> 
> the added config-config options are taken from config-6.5.13-6-pve
> (the restore-image is still based on kernel 6.5) - and I tried copying
> a small set around the needed options.

maybe we should upgrade to a newer one at some point (might also benefit
from NTFS bug fixes and added features..)

> 
> with the patch the ESP contents are shown successfully
> 
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
>  src/config-base | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/src/config-base b/src/config-base
> index 1581b09..238d93c 100644
> --- a/src/config-base
> +++ b/src/config-base
> @@ -144,6 +144,11 @@ CONFIG_ISO9660_FS=y
>  CONFIG_NTFS3_FS=y
>  CONFIG_MSDOS_FS=y
>  CONFIG_VFAT_FS=y
> +CONFIG_FAT_DEFAULT_CODEPAGE=437
> +CONFIG_FAT_DEFAULT_IOCHARSET="iso8859-1"

these two are the default values anyway and already set without this
patch?

> +CONFIG_NLS=y

this one is set as well

> +CONFIG_NLS_DEFAULT="utf8"

the upstream default for this is iso8859-1, but it also says this is
"the NLS used by your console, not the NLS used by a specific file
system (if different) to store data (filenames) on disk." - whatever
that means exactly?

> +CONFIG_NLS_CODEPAGE_437=y

shouldn't we also enable NLS_UTF8 ?

I mean, I guess it doesn't really matter as long as we don't start
setting the corresponding mount options to force a specific codepage?

the last option seems to be the only one that is actually missing from
our config ;) althoug hit doesn't hurt to set any of the above
explicitly I guess..

>  
>  # memory hotplug
>  CONFIG_MEMORY_HOTPLUG=y
> -- 
> 2.39.5
> 
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> 
> 
> 


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

Re: [pbs-devel] [PATCH proxmox-backup-restore-image] kernel: enable codepage 437 for vfat support

[Thomas Lamprecht]

Am 26.11.24 um 13:26 schrieb Fabian Grünbichler:
> On November 26, 2024 1:03 pm, Stoiko Ivanov wrote:
>> ran into an issue when clicking on the ESP of a VM while trying
>> single-file restore.
>>
>> the added config-config options are taken from config-6.5.13-6-pve
>> (the restore-image is still based on kernel 6.5) - and I tried copying
>> a small set around the needed options.
> maybe we should upgrade to a newer one at some point (might also benefit
> from NTFS bug fixes and added features..)

Yes, I would go directly to 6.11 once we got a new tag from ubuntu and
after the releases, maybe ZFS 2.3 is done by then, which could be also
nice to have then (albeit I did not check if that would provide new
pool-features that 2.2 does not understands)


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

Re: [pbs-devel] [PATCH proxmox-backup-restore-image] kernel: enable codepage 437 for vfat support

[Stoiko Ivanov]

Thanks for the quick feedback!

On Tue, 26 Nov 2024 13:26:47 +0100
Fabian Grünbichler <f.gruenbichler@proxmox.com> wrote:

> adding missing subject prefix ;)
missed that part before sending a v2:
https://lore.proxmox.com/pbs-devel/20241126132602.576027-1-s.ivanov@proxmox.com/T/#u
(fixed now)

> 
> On November 26, 2024 1:03 pm, Stoiko Ivanov wrote:
> > ran into an issue when clicking on the ESP of a VM while trying
> > single-file restore.
> > 
> > the added config-config options are taken from config-6.5.13-6-pve
> > (the restore-image is still based on kernel 6.5) - and I tried copying
> > a small set around the needed options.  
> 
> maybe we should upgrade to a newer one at some point (might also benefit
> from NTFS bug fixes and added features..)
sounds sensible! - anyone got an idea how wide-spread EXFAT is (because it
is set in our regular-kernels (just after the VFAT-options))?
quick skim through the config for 6.11 did not yield anything else new that
seems too common (on guests).



> 
> > 
> > with the patch the ESP contents are shown successfully
> > 
> > Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> > ---
> >  src/config-base | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/src/config-base b/src/config-base
> > index 1581b09..238d93c 100644
> > --- a/src/config-base
> > +++ b/src/config-base
> > @@ -144,6 +144,11 @@ CONFIG_ISO9660_FS=y
> >  CONFIG_NTFS3_FS=y
> >  CONFIG_MSDOS_FS=y
> >  CONFIG_VFAT_FS=y
> > +CONFIG_FAT_DEFAULT_CODEPAGE=437
> > +CONFIG_FAT_DEFAULT_IOCHARSET="iso8859-1"  
> 
> these two are the default values anyway and already set without this
> patch?
yes - I sent the patch a bit too soon after my first test and before
taking the 2 minutes to look around the config file

> 
> > +CONFIG_NLS=y  
> 
> this one is set as well
> 
> > +CONFIG_NLS_DEFAULT="utf8"  
> 
> the upstream default for this is iso8859-1, but it also says this is
> "the NLS used by your console, not the NLS used by a specific file
> system (if different) to store data (filenames) on disk." - whatever
> that means exactly?
> 
> > +CONFIG_NLS_CODEPAGE_437=y  
> 
> shouldn't we also enable NLS_UTF8 ?
> 
> I mean, I guess it doesn't really matter as long as we don't start
> setting the corresponding mount options to force a specific codepage?
can't remember ever needing to set any code-page specific options for vfat
in quite a long time (and mounting various images for uncommon uses)
so I'd say - let's see if anyone runs into needing this.

> 
> the last option seems to be the only one that is actually missing from
> our config ;) althoug hit doesn't hurt to set any of the above
> explicitly I guess..
I think keeping this as minimal as needed makes sense, thus tested with
only `CONFIG_NLS_CODEPAGE_437=y` set - and decided to stick with that, as
it worked with a partition created with mkfs.vfat (the ESP from debian).



> 
> >  
> >  # memory hotplug
> >  CONFIG_MEMORY_HOTPLUG=y
> > -- 
> > 2.39.5
> > 
> > 
> > 
> > _______________________________________________
> > pbs-devel mailing list
> > pbs-devel@lists.proxmox.com
> > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> > 
> > 
> >   
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> 
> 



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

Re: [pbs-devel] [PATCH proxmox-backup-restore-image] kernel: enable codepage 437 for vfat support

[Fabian Grünbichler]

On November 26, 2024 2:42 pm, Stoiko Ivanov wrote:
> Thanks for the quick feedback!
> 
> On Tue, 26 Nov 2024 13:26:47 +0100
> Fabian Grünbichler <f.gruenbichler@proxmox.com> wrote:
> 
>> adding missing subject prefix ;)
> missed that part before sending a v2:
> https://lore.proxmox.com/pbs-devel/20241126132602.576027-1-s.ivanov@proxmox.com/T/#u
> (fixed now)
> 
>> 
>> On November 26, 2024 1:03 pm, Stoiko Ivanov wrote:
>> > ran into an issue when clicking on the ESP of a VM while trying
>> > single-file restore.
>> > 
>> > the added config-config options are taken from config-6.5.13-6-pve
>> > (the restore-image is still based on kernel 6.5) - and I tried copying
>> > a small set around the needed options.  
>> 
>> maybe we should upgrade to a newer one at some point (might also benefit
>> from NTFS bug fixes and added features..)
> sounds sensible! - anyone got an idea how wide-spread EXFAT is (because it
> is set in our regular-kernels (just after the VFAT-options))?
> quick skim through the config for 6.11 did not yield anything else new that
> seems too common (on guests).

I mostly encounter it as the factory default for some external storage
media, but I am a 99,5% Linux user so I don't know whether there's some
Windows corner that makes it more widespread in a VM context..


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

Re: [pbs-devel] [PATCH proxmox-backup-restore-image] kernel: enable codepage 437 for vfat support

[Stoiko Ivanov]

On Tue, 26 Nov 2024 13:30:17 +0100
Thomas Lamprecht <t.lamprecht@proxmox.com> wrote:

> Am 26.11.24 um 13:26 schrieb Fabian Grünbichler:
> 
> Yes, I would go directly to 6.11 once we got a new tag from ubuntu and
> after the releases, maybe ZFS 2.3 is done by then, which could be also
> nice to have then (albeit I did not check if that would provide new
> pool-features that 2.2 does not understands)
sounds sensible - the issue has been around for at least one year (change
to kernel 6.5) - and I'm not aware that anyone has run into it yet, apart
from my test - so no particular rush there

as for ZFS 2.3 - I assume that fast dedup[0] and long-names [1] might be
features that are not read-only compatible (but did not check the code
closely) - for raid-Z expansion - the pull-request mentions that it's not
read-only compatible.

I'll try to update the kernel+zfs here when looking into ZFS-2.3.0

[0] https://github.com/openzfs/zfs/discussions/15896
[1] https://github.com/openzfs/zfs/pull/15921
[2] https://github.com/openzfs/zfs/pull/15022


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel