* [pbs-devel] [PATCH proxmox-backup 1/1] client: fix example commands for client usage
@ 2024-11-26 11:04 Stefan Hanreich
2024-11-26 11:09 ` [pbs-devel] applied: " Fabian Grünbichler
2024-11-26 11:12 ` [pbs-devel] " Thomas Lamprecht
0 siblings, 2 replies; 4+ messages in thread
From: Stefan Hanreich @ 2024-11-26 11:04 UTC (permalink / raw)
To: pbs-devel
The example commands in the Change Detection Mode / File Exclusion
section are missing the command in the client invocation. Add the
backup command to the examples, so they are actually valid.
Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---
docs/backup-client.rst | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/docs/backup-client.rst b/docs/backup-client.rst
index 3c6941ae..f2b5273c 100644
--- a/docs/backup-client.rst
+++ b/docs/backup-client.rst
@@ -272,13 +272,13 @@ parameter. For example:
.. code-block:: console
- # proxmox-backup-client backup.pxar:./linux --exclude /usr
+ # proxmox-backup-client backup backup.pxar:./linux --exclude /usr
Multiple paths can be excluded like this:
.. code-block:: console
- # proxmox-backup-client backup.pxar:./linux --exclude=/usr --exclude=/rust
+ # proxmox-backup-client backup backup.pxar:./linux --exclude=/usr --exclude=/rust
.. _client_change_detection_mode:
@@ -329,7 +329,7 @@ mode:
.. code-block:: console
- # proxmox-backup-client backup.pxar:./linux --change-detection-mode=metadata
+ # proxmox-backup-client backup backup.pxar:./linux --change-detection-mode=metadata
.. _client_encryption:
--
2.39.5
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* [pbs-devel] applied: [PATCH proxmox-backup 1/1] client: fix example commands for client usage
2024-11-26 11:04 [pbs-devel] [PATCH proxmox-backup 1/1] client: fix example commands for client usage Stefan Hanreich
@ 2024-11-26 11:09 ` Fabian Grünbichler
2024-11-26 11:12 ` [pbs-devel] " Thomas Lamprecht
1 sibling, 0 replies; 4+ messages in thread
From: Fabian Grünbichler @ 2024-11-26 11:09 UTC (permalink / raw)
To: Proxmox Backup Server development discussion
thanks!
On November 26, 2024 12:04 pm, Stefan Hanreich wrote:
> The example commands in the Change Detection Mode / File Exclusion
> section are missing the command in the client invocation. Add the
> backup command to the examples, so they are actually valid.
>
> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
> ---
> docs/backup-client.rst | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/docs/backup-client.rst b/docs/backup-client.rst
> index 3c6941ae..f2b5273c 100644
> --- a/docs/backup-client.rst
> +++ b/docs/backup-client.rst
> @@ -272,13 +272,13 @@ parameter. For example:
>
> .. code-block:: console
>
> - # proxmox-backup-client backup.pxar:./linux --exclude /usr
> + # proxmox-backup-client backup backup.pxar:./linux --exclude /usr
>
> Multiple paths can be excluded like this:
>
> .. code-block:: console
>
> - # proxmox-backup-client backup.pxar:./linux --exclude=/usr --exclude=/rust
> + # proxmox-backup-client backup backup.pxar:./linux --exclude=/usr --exclude=/rust
>
> .. _client_change_detection_mode:
>
> @@ -329,7 +329,7 @@ mode:
>
> .. code-block:: console
>
> - # proxmox-backup-client backup.pxar:./linux --change-detection-mode=metadata
> + # proxmox-backup-client backup backup.pxar:./linux --change-detection-mode=metadata
>
> .. _client_encryption:
>
> --
> 2.39.5
>
>
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
>
>
>
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [pbs-devel] [PATCH proxmox-backup 1/1] client: fix example commands for client usage
2024-11-26 11:04 [pbs-devel] [PATCH proxmox-backup 1/1] client: fix example commands for client usage Stefan Hanreich
2024-11-26 11:09 ` [pbs-devel] applied: " Fabian Grünbichler
@ 2024-11-26 11:12 ` Thomas Lamprecht
2024-11-26 11:29 ` Stefan Hanreich
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Lamprecht @ 2024-11-26 11:12 UTC (permalink / raw)
To: Proxmox Backup Server development discussion, Stefan Hanreich
Am 26.11.24 um 12:04 schrieb Stefan Hanreich:
> The example commands in the Change Detection Mode / File Exclusion
> section are missing the command in the client invocation. Add the
> backup command to the examples, so they are actually valid.
>
> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
> ---
> docs/backup-client.rst | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/docs/backup-client.rst b/docs/backup-client.rst
> index 3c6941ae..f2b5273c 100644
> --- a/docs/backup-client.rst
> +++ b/docs/backup-client.rst
> @@ -272,13 +272,13 @@ parameter. For example:
>
> .. code-block:: console
>
> - # proxmox-backup-client backup.pxar:./linux --exclude /usr
> + # proxmox-backup-client backup backup.pxar:./linux --exclude /usr
>
> Multiple paths can be excluded like this:
>
> .. code-block:: console
>
> - # proxmox-backup-client backup.pxar:./linux --exclude=/usr --exclude=/rust
> + # proxmox-backup-client backup backup.pxar:./linux --exclude=/usr --exclude=/rust
>
> .. _client_change_detection_mode:
>
> @@ -329,7 +329,7 @@ mode:
>
> .. code-block:: console
>
> - # proxmox-backup-client backup.pxar:./linux --change-detection-mode=metadata
> + # proxmox-backup-client backup backup.pxar:./linux --change-detection-mode=metadata
Fabian already applied this, but I'd also change the target pxar file name,
using "backup" for that is probably the the source of the original mistake
and is IMO quite likely to confuse users, double words are often skipped
unconsciously by the brain (for some proven if they have missed the double
the in the second line ;)
>
> .. _client_encryption:
>
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [pbs-devel] [PATCH proxmox-backup 1/1] client: fix example commands for client usage
2024-11-26 11:12 ` [pbs-devel] " Thomas Lamprecht
@ 2024-11-26 11:29 ` Stefan Hanreich
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Hanreich @ 2024-11-26 11:29 UTC (permalink / raw)
To: Thomas Lamprecht, Proxmox Backup Server development discussion
On 11/26/24 12:12, Thomas Lamprecht wrote:
> Fabian already applied this, but I'd also change the target pxar file name,
> using "backup" for that is probably the the source of the original mistake
> and is IMO quite likely to confuse users, double words are often skipped
> unconsciously by the brain (for some proven if they have missed the double
> the in the second line ;)
that is true indeed, sent another patch ;)
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-11-26 11:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-26 11:04 [pbs-devel] [PATCH proxmox-backup 1/1] client: fix example commands for client usage Stefan Hanreich
2024-11-26 11:09 ` [pbs-devel] applied: " Fabian Grünbichler
2024-11-26 11:12 ` [pbs-devel] " Thomas Lamprecht
2024-11-26 11:29 ` Stefan Hanreich
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.