[pve-devel] [PATCH proxmox-widget-toolkit] utils: never translate systemd unit states

[pve-devel] [PATCH proxmox-widget-toolkit] utils: never translate systemd unit states

[Christian Ebner]

Translating unit states might be counter productive in case of
debugging, opt for not translating them and drop usage of the
translation helper.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 src/Utils.js            | 12 ------------
 src/node/ServiceView.js | 10 ++--------
 2 files changed, 2 insertions(+), 20 deletions(-)

diff --git a/src/Utils.js b/src/Utils.js
index 978b558..1ee4039 100644
--- a/src/Utils.js
+++ b/src/Utils.js
@@ -306,18 +306,6 @@ utilities: {
 	return Ext.htmlEncode(username);
     },
 
-    systemdStates: {
-	'enabled': gettext('enabled'),
-	'disabled': gettext('disabled'),
-	'running': gettext('running'),
-	'dead': gettext('dead'),
-	'not-found': gettext('not installed'),
-	'static': gettext('static'),
-	'reload': gettext('reload'),
-	'start': gettext('starting'),
-	'stop': gettext('stopping'),
-    },
-
     getStoredAuth: function() {
 	let storedAuth = JSON.parse(window.localStorage.getItem('ProxmoxUser'));
 	return storedAuth || {};
diff --git a/src/node/ServiceView.js b/src/node/ServiceView.js
index 94f523c..210dd83 100644
--- a/src/node/ServiceView.js
+++ b/src/node/ServiceView.js
@@ -201,10 +201,7 @@ Ext.define('Proxmox.node.ServiceView', {
 		    width: 100,
 		    sortable: true,
 		    dataIndex: 'state',
-		    renderer: (value, meta, rec) => {
-			const state = rec.get('state');
-			return Proxmox.Utils.systemdStates[state] ?? state;
-		    },
+		    renderer: (value, meta, rec) => rec.get('state'),
 		},
 		{
 		    header: gettext('Active'),
@@ -219,10 +216,7 @@ Ext.define('Proxmox.node.ServiceView', {
 		    sortable: true,
 		    hidden: !Ext.Array.contains(['PVEAuthCookie', 'PBSAuthCookie'], Proxmox?.Setup?.auth_cookie_name),
 		    dataIndex: 'unit-state',
-		    renderer: (value, meta, rec) => {
-			const unitState = rec.get('unit-state');
-			return Proxmox.Utils.systemdStates[unitState] ?? unitState;
-		    },
+		    renderer: (value, meta, rec) => rec.get('unit-state'),
 		},
 		{
 		    header: gettext('Description'),
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH proxmox-widget-toolkit] utils: never translate systemd unit states

[Thomas Lamprecht]

Am 19.11.24 um 14:02 schrieb Christian Ebner:
> Translating unit states might be counter productive in case of
> debugging, opt for not translating them and drop usage of the
> translation helper.
> 
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
>  src/Utils.js            | 12 ------------
>  src/node/ServiceView.js | 10 ++--------
>  2 files changed, 2 insertions(+), 20 deletions(-)
> 
>

applied, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel