From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH cluster 1/1] cfs: add 'sdn/mac-cache.json' to observed files
Date: Mon, 18 Nov 2024 21:55:36 +0100 [thread overview]
Message-ID: <20241118205537.3136251-2-s.ivanov@proxmox.com> (raw)
In-Reply-To: <20241118205537.3136251-1-s.ivanov@proxmox.com>
follows commit:
d8ef05c (cfs: add 'sdn/pve-ipam-state.json' to observed files)
with the same motivation - the data in the macs.db file is a cache, to
prevent unneccessary lookups to external IPAM modules - is not private
in the sense of secrets for external resources.
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
src/PVE/Cluster.pm | 3 ++-
src/pmxcfs/status.c | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/PVE/Cluster.pm b/src/PVE/Cluster.pm
index 28ebcfe..e0e3ee9 100644
--- a/src/PVE/Cluster.pm
+++ b/src/PVE/Cluster.pm
@@ -62,7 +62,7 @@ my $observed = {
'priv/token.cfg' => 1,
'priv/acme/plugins.cfg' => 1,
'priv/ipam.db' => 1, # TODO: replaced by sdn/ipam-pve-db.json, remove in PVE 9+
- 'priv/macs.db' => 1,
+ 'priv/macs.db' => 1, # TODO: replaced by sdn/mac-cache.json, remove in PVE 9+
'/qemu-server/' => 1,
'/openvz/' => 1,
'/lxc/' => 1,
@@ -79,6 +79,7 @@ my $observed = {
'sdn/subnets.cfg' => 1,
'sdn/ipams.cfg' => 1,
'sdn/pve-ipam-state.json' => 1,
+ 'sdn/mac-cache.json' => 1,
'sdn/dns.cfg' => 1,
'sdn/.running-config' => 1,
'virtual-guest/cpu-models.conf' => 1,
diff --git a/src/pmxcfs/status.c b/src/pmxcfs/status.c
index 6e5d4fb..ff5fcc4 100644
--- a/src/pmxcfs/status.c
+++ b/src/pmxcfs/status.c
@@ -89,7 +89,7 @@ static memdb_change_t memdb_change_array[] = {
{ .path = "priv/tfa.cfg" },
{ .path = "priv/token.cfg" },
{ .path = "priv/ipam.db" }, // TODO: replaced by sdn/ipam-pve-db.json remove with PVE 9 or later
- { .path = "priv/macs.db" },
+ { .path = "priv/macs.db" }, // TODO: replaced by sdn/mac-cache.json remove with PVE 9 or later
{ .path = "datacenter.cfg" },
{ .path = "vzdump.cron" },
{ .path = "vzdump.conf" },
@@ -107,6 +107,7 @@ static memdb_change_t memdb_change_array[] = {
{ .path = "sdn/controllers.cfg" },
{ .path = "sdn/subnets.cfg" },
{ .path = "sdn/ipams.cfg" },
+ { .path = "sdn/mac-cache.json" },
{ .path = "sdn/pve-ipam-state.json" },
{ .path = "sdn/dns.cfg" },
{ .path = "sdn/.running-config" },
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-11-18 20:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-18 20:55 [pve-devel] [pve-cluster/pve-network] move macs.db from priv/ to sdn/ Stoiko Ivanov
2024-11-18 20:55 ` Stoiko Ivanov [this message]
2024-11-18 20:55 ` [pve-devel] [pve-network 1/1] ipam: move mac-cache.db to unprivileged sdn/ subdirectory Stoiko Ivanov
2024-11-18 21:22 ` [pve-devel] applied: [pve-cluster/pve-network] move macs.db from priv/ to sdn/ Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241118205537.3136251-2-s.ivanov@proxmox.com \
--to=s.ivanov@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.