[pbs-devel] [PATCH] ui tasks: use view task instead of open task

[pbs-devel] [PATCH] ui tasks: use view task instead of open task

[Aaron Lauterer]

This aligns the tooltips to how we have in in Proxmox VE. Using "view"
instead of "open" should make it clear, that this is a safe read-only
action.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
---
Matching patches for PVE in the pve-devel list:
https://lore.proxmox.com/pve-devel/20241118104530.91798-1-a.lauterer@proxmox.com/T/#t

 www/dashboard/LongestTasks.js | 2 +-
 www/dashboard/RunningTasks.js | 2 +-
 www/dashboard/TaskSummary.js  | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/www/dashboard/LongestTasks.js b/www/dashboard/LongestTasks.js
index 20cf1183..f405b98f 100644
--- a/www/dashboard/LongestTasks.js
+++ b/www/dashboard/LongestTasks.js
@@ -100,7 +100,7 @@ Ext.define('PBS.LongestTasks', {
 	    items: [
 		{
 		    iconCls: 'fa fa-chevron-right',
-		    tooltip: gettext('Open Task'),
+		    tooltip: gettext('View Task'),
 		    handler: 'openTaskActionColumn',
 		},
 	    ],
diff --git a/www/dashboard/RunningTasks.js b/www/dashboard/RunningTasks.js
index 4529d0d3..20a7c51e 100644
--- a/www/dashboard/RunningTasks.js
+++ b/www/dashboard/RunningTasks.js
@@ -95,7 +95,7 @@ Ext.define('PBS.RunningTasks', {
 	    items: [
 		{
 		    iconCls: 'fa fa-chevron-right',
-		    tooltip: gettext('Open Task'),
+		    tooltip: gettext('View Task'),
 		    handler: 'openTaskActionColumn',
 		},
 	    ],
diff --git a/www/dashboard/TaskSummary.js b/www/dashboard/TaskSummary.js
index 68f6f6ef..684a18f0 100644
--- a/www/dashboard/TaskSummary.js
+++ b/www/dashboard/TaskSummary.js
@@ -109,7 +109,7 @@ Ext.define('PBS.TaskSummary', {
 				items: [
 				    {
 					iconCls: 'fa fa-chevron-right',
-					tooltip: gettext('Open Task'),
+					tooltip: gettext('View Task'),
 					handler: function(g, rowIndex) {
 					    let rec = tasklist.getStore().getAt(rowIndex);
 					    tasklist.setVisible(false);
-- 
2.39.5



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[pbs-devel] applied: [PATCH] ui tasks: use view task instead of open task

[Thomas Lamprecht]

On Mon, 18 Nov 2024 11:49:59 +0100, Aaron Lauterer wrote:
> This aligns the tooltips to how we have in in Proxmox VE. Using "view"
> instead of "open" should make it clear, that this is a safe read-only
> action.
> 
> 

Applied, thanks!

[1/1] ui tasks: use view task instead of open task
      commit: e98e96290452286e8a9704f93105ea81877eabb0


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel