From: Aaron Lauterer <a.lauterer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager v3 3/3] ui: tasks: add actioncolumn to open task
Date: Mon, 18 Nov 2024 11:45:30 +0100 [thread overview]
Message-ID: <20241118104530.91798-4-a.lauterer@proxmox.com> (raw)
In-Reply-To: <20241118104530.91798-1-a.lauterer@proxmox.com>
Many (new) users don't realize that the task view can be used to open
the task details.
By adding a small action column we can have a button to open the task as
well, next to double clicking it.
Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
---
I placed the actioncolumn at the end. See the cover letter for the
reasoning. Placing it anywhere else in the grid should just be a
yank/paste.
change since v2:
* use "View Task" instead of "Show Task" in the tooltip
v1:
* use the `rec` parameter directly instead of fetching if from the grid
store
www/manager6/dc/Tasks.js | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/www/manager6/dc/Tasks.js b/www/manager6/dc/Tasks.js
index 9405f9a2..c43218ce 100644
--- a/www/manager6/dc/Tasks.js
+++ b/www/manager6/dc/Tasks.js
@@ -127,6 +127,25 @@ Ext.define('PVE.dc.Tasks', {
return Proxmox.Utils.format_task_status(value);
},
},
+ {
+ xtype: 'actioncolumn',
+ width: 30,
+ align: 'center',
+ tooltip: gettext('Actions'),
+ items: [
+ {
+ iconCls: 'fa fa-chevron-right',
+ tooltip: gettext('View Task'),
+ handler: function(_grid, _rowIndex, _colIndex, _item, _e, rec) {
+ Ext.create('Proxmox.window.TaskViewer', {
+ autoShow: true,
+ upid: rec.data.upid,
+ endtime: rec.data.endtime,
+ });
+ },
+ },
+ ],
+ },
],
listeners: {
itemdblclick: run_task_viewer,
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-11-18 10:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-18 10:45 [pve-devel] [PATCH widget-toolkit, manager v3 0/3] ui: tasks: add button to Aaron Lauterer
2024-11-18 10:45 ` [pve-devel] [PATCH widget-toolkit v3 1/3] node tasks: add action column with button to view task Aaron Lauterer
2024-11-18 10:45 ` [pve-devel] [PATCH widget-toolkit v3 2/3] node tasks: align view task button label to other uses Aaron Lauterer
2024-11-18 10:45 ` Aaron Lauterer [this message]
2025-03-24 12:41 ` [pve-devel] [PATCH widget-toolkit, manager v3 0/3] ui: tasks: add button to Friedrich Weber
2025-04-04 14:40 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241118104530.91798-4-a.lauterer@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.