From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH] fix #5869: d/postinst: do not fail if ifreload fails on first install
Date: Wed, 13 Nov 2024 20:01:13 +0100 [thread overview]
Message-ID: <20241113190113.678807-1-s.ivanov@proxmox.com> (raw)
erroring out here will not help getting a running network, therefore
just log a warning.
Tested the original reporters case (running in a debootstrap) with:
```
mmdebstrap \
--variant=minbase \
--include=/tmp/ifupdown2_3.2.0-1+pmx10_all.deb \
--hook-dir=/usr/share/mmdebstrap/hooks/file-mirror-automount \
bookworm \
./bookworm-amd64.tar.zst
```
ran through our install on plain debian guide:
https://pve.proxmox.com/wiki/Install_Proxmox_VE_on_Debian_12_Bookworm
with this package in a local repository to check for regressions
adding the reference to the commit that introduced the reload on
first-install, as this got shifted around a bit and it took me too
long to see that we did not want to error out here on purpose
Fixes: 86335f3f898c59864a09a3e13b8146c0a0ea079d
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
debian/ifupdown2.postinst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/debian/ifupdown2.postinst b/debian/ifupdown2.postinst
index 0137ea8..a22b825 100644
--- a/debian/ifupdown2.postinst
+++ b/debian/ifupdown2.postinst
@@ -114,7 +114,7 @@ case "$1" in
if [ -f "/tmp/.ifupdown2-first-install" ] && [ ! -e /proxmox_install_mode ]; then
proxmox_compatibility
echo "Reloading network config on first install"
- ifreload -a
+ ifreload -a || report_warn "Reloading failed"
rm /tmp/.ifupdown2-first-install
fi
;;
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2024-11-13 19:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-13 19:01 Stoiko Ivanov [this message]
2024-11-14 17:37 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241113190113.678807-1-s.ivanov@proxmox.com \
--to=s.ivanov@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.