From: Timothy Nicholson <t.nicholson@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager v4] fix #5810: ui: show confirmation/warning dialog for sdn apply
Date: Tue, 12 Nov 2024 14:15:09 +0100 [thread overview]
Message-ID: <20241112131509.159661-1-t.nicholson@proxmox.com> (raw)
Signed-off-by: Timothy Nicholson <t.nicholson@proxmox.com>
---
changes since v3 [0]:
- implement conditional warning message that displays which node(s)
have pending changes.
I'd be thankful for any feedback, as this can probably be refined in
some way.
[0]: https://lore.proxmox.com/pve-devel/20241112120255.127300-1-t.nicholson@proxmox.com/
www/manager6/sdn/StatusView.js | 48 +++++++++++++++++++++++++++-------
1 file changed, 39 insertions(+), 9 deletions(-)
diff --git a/www/manager6/sdn/StatusView.js b/www/manager6/sdn/StatusView.js
index 970aa919..009f5fee 100644
--- a/www/manager6/sdn/StatusView.js
+++ b/www/manager6/sdn/StatusView.js
@@ -40,16 +40,46 @@ Ext.define('PVE.sdn.StatusView', {
tbar: [
{
text: gettext('Apply'),
- handler: function() {
- Proxmox.Utils.API2Request({
- url: '/cluster/sdn/',
- method: 'PUT',
- waitMsgTarget: me,
- failure: function(response, opts) {
- Ext.Msg.alert(gettext('Error'), response.htmlStatus);
- },
- });
+ handler: async function() {
+ const applyChanges = () => {
+ Proxmox.Utils.API2Request({
+ url: '/cluster/sdn',
+ method: 'PUT',
+ waitMsgTarget: me,
+ failure: response => Ext.Msg.alert(gettext('Error'), response.htmlStatus),
+ });
+ };
+
+ let nodesPending = [];
+ let { result: nodesResult } = await Proxmox.Async.api2({ url: '/nodes' });
+
+ await Promise.all(nodesResult.data.map(async(node) => {
+ let { result: networkResult } = await
+ Proxmox.Async.api2({ url: `/nodes/${node.node}/network` });
+ if (networkResult.changes !== undefined) {
+ nodesPending.push(node.node);
+ }
+ }));
+
+ if (nodesPending.length > 0) {
+ Ext.Msg.show({
+ title: gettext('Confirm'),
+ msg: `${gettext('There are pending network changes on node(s)')} [${nodesPending}]. ` +
+ `${gettext('These will also be applied. Proceed?')}`,
+ icon: Ext.Msg.QUESTION,
+ buttons: Ext.Msg.YESNO,
+ callback: function(btn) {
+ if (btn === 'yes') {
+ applyChanges();
+ }
+ },
+ });
+ } else {
+ applyChanges();
+ }
},
+
+
},
],
viewConfig: {
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
reply other threads:[~2024-11-12 13:15 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241112131509.159661-1-t.nicholson@proxmox.com \
--to=t.nicholson@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.