* [pve-devel] [PATCH installer] installer-common: do not drop nomodeset from target kernel cmdline
@ 2024-10-30 9:59 Stoiko Ivanov
2024-11-10 18:19 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Stoiko Ivanov @ 2024-10-30 9:59 UTC (permalink / raw)
To: pve-devel
dropping the `nomodeset` here makes little sense:
* currently users need to explicitly add it when booting the kernel,
which is probably only done when the system needs it to show any
output when booting
* it was originally removed, because the installer had a grub-entry
that explicitly disabled it - and the reasoning was to remove
everything installer-specific - but I assume that it should cause
less problems to keep it in place in all cases.
This was also partially pointed to in:
https://bugzilla.proxmox.com/show_bug.cgi?id=4230#c38
Fixes: a02a78a865fc37f7bdea077a4421319b84c635c9
Suggested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
minimally tested by redoing the change in the second debug shell and
installing in a VM w/ secure boot disabled (nomodeset breaks the
debugshells if secureboot is enabled)
one remaining question is if we want to also preserve the vga=\S+
parameter:
* we set it for the TUI-installer options (to vga=788) - so this might
warrant removal
* while I assume that most cases where the TUI installer is used are
either due to UX-preference, or to workaround issues with x.org -
there might be cases where keeping it present ensures that the
target system has a sensible/readabl console at all
* if someone explicitly set it, it will get removed, so keeping all
options apart from vga=788 might be a sensible improvment in any
case
will gladly send a follow-up for this
Proxmox/Install/Config.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Proxmox/Install/Config.pm b/Proxmox/Install/Config.pm
index ae70093..49c247b 100644
--- a/Proxmox/Install/Config.pm
+++ b/Proxmox/Install/Config.pm
@@ -44,7 +44,7 @@ my sub parse_kernel_cmdline {
}
$cmdline =~ s/(?:BOOT_IMAGE|root|ramdisk_size|splash|vga)=\S+\s?//gi;
- $cmdline =~ s/ro|rw|quiet|proxdebug|proxtui|nomodeset//gi;
+ $cmdline =~ s/ro|rw|quiet|proxdebug|proxtui//gi;
$cfg->{target_cmdline}= $cmdline;
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH installer] installer-common: do not drop nomodeset from target kernel cmdline
2024-10-30 9:59 [pve-devel] [PATCH installer] installer-common: do not drop nomodeset from target kernel cmdline Stoiko Ivanov
@ 2024-11-10 18:19 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2024-11-10 18:19 UTC (permalink / raw)
To: Proxmox VE development discussion, Stoiko Ivanov
Am 30.10.24 um 10:59 schrieb Stoiko Ivanov:
> dropping the `nomodeset` here makes little sense:
> * currently users need to explicitly add it when booting the kernel,
> which is probably only done when the system needs it to show any
> output when booting
> * it was originally removed, because the installer had a grub-entry
> that explicitly disabled it - and the reasoning was to remove
> everything installer-specific - but I assume that it should cause
> less problems to keep it in place in all cases.
>
> This was also partially pointed to in:
> https://bugzilla.proxmox.com/show_bug.cgi?id=4230#c38
>
> Fixes: a02a78a865fc37f7bdea077a4421319b84c635c9
> Suggested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> minimally tested by redoing the change in the second debug shell and
> installing in a VM w/ secure boot disabled (nomodeset breaks the
> debugshells if secureboot is enabled)
>
> one remaining question is if we want to also preserve the vga=\S+
> parameter:
> * we set it for the TUI-installer options (to vga=788) - so this might
> warrant removal
> * while I assume that most cases where the TUI installer is used are
> either due to UX-preference, or to workaround issues with x.org -
> there might be cases where keeping it present ensures that the
> target system has a sensible/readabl console at all
> * if someone explicitly set it, it will get removed, so keeping all
> options apart from vga=788 might be a sensible improvment in any
> case
>
> will gladly send a follow-up for this
>
> Proxmox/Install/Config.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-11-10 18:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-30 9:59 [pve-devel] [PATCH installer] installer-common: do not drop nomodeset from target kernel cmdline Stoiko Ivanov
2024-11-10 18:19 ` [pve-devel] applied: " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal