[pve-devel] [PATCH manager 1/2] api: cluster resources: add lock and tags to return schema

[pve-devel] [PATCH manager 1/2] api: cluster resources: add lock and tags to return schema

[Dominik Csapak]

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 PVE/API2/Cluster.pm | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/PVE/API2/Cluster.pm b/PVE/API2/Cluster.pm
index ba3c9528..2b53213f 100644
--- a/PVE/API2/Cluster.pm
+++ b/PVE/API2/Cluster.pm
@@ -315,6 +315,11 @@ __PACKAGE__->register_method({
 		    type => 'string',
 		    optional => 1,
 		},
+		lock => {
+		    description => "The current config lock of the guets (type in qemu,lxc)",
+		    type => 'string',
+		    optional => 1,
+		},
 		uptime => {
 		    description => "Uptime of node or virtual guest in seconds (when type in node,qemu,lxc).",
 		    type => 'integer',
@@ -376,6 +381,11 @@ __PACKAGE__->register_method({
 		    type => 'integer',
 		    optional => 1,
 		},
+		tags => {
+		    description => "The set tags of the guest (type in qemu,lxc)",
+		    type  => "string",
+		    optional => 1,
+		},
 		template => {
 		    description => "Determines if the guest is a template. (type in qemu,lxc)",
 		    type => 'boolean',
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH manager 2/2] api: tasks: fix return type of 'starttime'

[Dominik Csapak]

starttime is parsed from a upid with perls `hex` which always returns an
integer

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 PVE/API2/Tasks.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PVE/API2/Tasks.pm b/PVE/API2/Tasks.pm
index 4ea9832b..ae60d846 100644
--- a/PVE/API2/Tasks.pm
+++ b/PVE/API2/Tasks.pm
@@ -480,7 +480,7 @@ __PACKAGE__->register_method({
 		type => 'string',
 	    },
 	    starttime => {
-		type => 'number',
+		type => 'integer',
 	    },
 	    pstart => {
 		type => 'integer',
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied-series: [PATCH manager 1/2] api: cluster resources: add lock and tags to return schema

[Wolfgang Bumiller]

applied this with a followup to unify the way we document the types
across this entire object (plus line-wrapping fixups and some minor typo
& phrasing fixes...)

On Fri, Oct 25, 2024 at 04:15:10PM GMT, Dominik Csapak wrote:
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  PVE/API2/Cluster.pm | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/PVE/API2/Cluster.pm b/PVE/API2/Cluster.pm
> index ba3c9528..2b53213f 100644
> --- a/PVE/API2/Cluster.pm
> +++ b/PVE/API2/Cluster.pm
> @@ -315,6 +315,11 @@ __PACKAGE__->register_method({
>  		    type => 'string',
>  		    optional => 1,
>  		},
> +		lock => {
> +		    description => "The current config lock of the guets (type in qemu,lxc)",
> +		    type => 'string',
> +		    optional => 1,
> +		},
>  		uptime => {
>  		    description => "Uptime of node or virtual guest in seconds (when type in node,qemu,lxc).",
>  		    type => 'integer',
> @@ -376,6 +381,11 @@ __PACKAGE__->register_method({
>  		    type => 'integer',
>  		    optional => 1,
>  		},
> +		tags => {
> +		    description => "The set tags of the guest (type in qemu,lxc)",
> +		    type  => "string",
> +		    optional => 1,
> +		},
>  		template => {
>  		    description => "Determines if the guest is a template. (type in qemu,lxc)",
>  		    type => 'boolean',
> -- 
> 2.39.5


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel