From: Gabriel Goller <g.goller@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH v2 proxmox-backup] partial fix #5560: client: periodically show backup progress
Date: Thu, 10 Oct 2024 12:50:21 +0200 [thread overview]
Message-ID: <20241010105021.xbmj2dtnypobmhoc@luna.proxmox.com> (raw)
In-Reply-To: <20241009092031.97601-1-c.ebner@proxmox.com>
On 09.10.2024 11:20, Christian Ebner wrote:
>Spawn a new tokio task which about every minute displays the
>cumulative progress of the backup for pxar, ppxar or img archive
>streams. Catalog and metadata archive streams are excluded from the
>output for better readability, and because the catalog upload lives
>for the whole upload time, leading to possible temporal
>misalignments in the output. The actual payload data is written via
>the other streams anyway.
>
>Add accounting for uploaded chunks, to distinguish from chunks queued
>for upload, but not actually uploaded yet.
>
>Example output in the backup task log:
>```
>...
>INFO: root.pxar: elapsed 60.00 s, new: 191.446 MiB, reused: 0 B, total: 191.446 MiB, uploaded: 13.021 MiB (compressed 5.327 MiB, average: 222.221 KiB/s)
>INFO: root.pxar: elapsed 120.00 s, new: 191.446 MiB, reused: 0 B, total: 191.446 MiB, uploaded: 27.068 MiB (compressed 11.583 MiB, average: 230.977 KiB/s)
>INFO: root.pxar: elapsed 180.00 s, new: 191.446 MiB, reused: 0 B, total: 191.446 MiB, uploaded: 36.138 MiB (compressed 14.987 MiB, average: 205.58 KiB/s)
>...
>```
>
>This partially fixes issue 5560:
>https://bugzilla.proxmox.com/show_bug.cgi?id=5560
>
>Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
>---
>Changes since version 1, thanks Gabriel for comments and testing:
>- Abort progress output task when upload stream is finished
>- Limit output to pxar, ppxar or img archives for cleaner output
>- Adapted commit title and message
>
> pbs-client/src/backup_writer.rs | 98 +++++++++++++++++++++++++++++----
> 1 file changed, 86 insertions(+), 12 deletions(-)
LGTM! Tested this through a few times and the output is way cleaner now.
Consider:
Tested-by: Gabriel Goller <g.goller@proxmox.com>
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-10-10 10:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-09 9:20 Christian Ebner
2024-10-10 10:50 ` Gabriel Goller [this message]
2024-10-10 14:45 ` Thomas Lamprecht
2024-10-10 15:25 ` Christian Ebner
2024-10-11 9:41 ` Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241010105021.xbmj2dtnypobmhoc@luna.proxmox.com \
--to=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.