From: Christoph Heiss <c.heiss@proxmox.com>
To: pmg-devel@lists.proxmox.com
Subject: [pmg-devel] [PATCH pmg-api v3 0/3] fix #4211: convert quarantine link mail to template
Date: Tue, 8 Oct 2024 13:17:50 +0200 [thread overview]
Message-ID: <20241008111753.831405-1-c.heiss@proxmox.com> (raw)
Fixes #4211 [0] by converting the currently hardcoded text for the
quarantine link mail to a proper template, enabling users to write their
own versions.
This series also adds the possibility to specify both a HTML and
plaintext template for PMG::Utils::finalize_report() (or just HTML, for
backwards compatibility) - as suggested in [1].
[0] https://bugzilla.proxmox.com/show_bug.cgi?id=4211
[1] https://lore.proxmox.com/pmg-devel/20241003172625.49655705@rosa.proxmox.com/
history
=======
v1: https://lore.proxmox.com/pmg-devel/20241001125948.605201-1-c.heiss@proxmox.com/
v2: https://lore.proxmox.com/pmg-devel/20241007103214.1006844-1-c.heiss@proxmox.com/
Notable changes v1 -> v2:
* add support for plaintext templates in addition to HTML
Notable changes v2 -> v3:
* add short documentation for email templates
diffstat
========
pmg-api:
Christoph Heiss (2):
utils: allow specifying plain and/or html for finalize_report()
fix #4211: convert quarantine link mail to template
src/Makefile | 2 ++
src/PMG/API2/Quarantine.pm | 22 ++++++------
src/PMG/Backup.pm | 5 +--
src/PMG/CLI/pmgqm.pm | 5 ++-
src/PMG/CLI/pmgreport.pm | 5 ++-
src/PMG/Utils.pm | 49 +++++++++++++++++++++++---
src/templates/quarantine-link.html.tt | 13 +++++++
src/templates/quarantine-link.plain.tt | 5 +++
8 files changed, 85 insertions(+), 21 deletions(-)
create mode 100644 src/templates/quarantine-link.html.tt
create mode 100644 src/templates/quarantine-link.plain.tt
pmg-docs:
Christoph Heiss (1):
pmgconfig: document support for html and plain-text email templates
pmgconfig.adoc | 8 ++++++++
1 file changed, 8 insertions(+)
--
2.46.0
_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
next reply other threads:[~2024-10-08 11:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 11:17 Christoph Heiss [this message]
2024-10-08 11:17 ` [pmg-devel] [PATCH pmg-api v3 1/3] utils: allow specifying plain and/or html for finalize_report() Christoph Heiss
2024-10-08 11:17 ` [pmg-devel] [PATCH pmg-api v3 2/3] fix #4211: convert quarantine link mail to template Christoph Heiss
2024-10-08 11:17 ` [pmg-devel] [PATCH pmg-docs v3 3/3] pmgconfig: document support for html and plain-text email templates Christoph Heiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241008111753.831405-1-c.heiss@proxmox.com \
--to=c.heiss@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.