From: Gabriel Goller <g.goller@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH widget-toolkit v4 3/7] form: add support for multiline textarea
Date: Fri, 13 Sep 2024 15:10:29 +0200 [thread overview]
Message-ID: <20240913131033.396324-4-g.goller@proxmox.com> (raw)
In-Reply-To: <20240913131033.396324-1-g.goller@proxmox.com>
This adds support for a editable multiline textarea in the ObjectGrid.
Now we can add a textarea row, which will open a textarea popup, and
encode the multi-line text into an base64 string (with utf8 support).
Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
---
src/Makefile | 1 +
src/form/TextAreaField.js | 60 +++++++++++++++++++++++++++++++++++++++
src/grid/ObjectGrid.js | 29 +++++++++++++++++++
3 files changed, 90 insertions(+)
create mode 100644 src/form/TextAreaField.js
diff --git a/src/Makefile b/src/Makefile
index 3c2fd4b0eb81..aa81bef17c84 100644
--- a/src/Makefile
+++ b/src/Makefile
@@ -31,6 +31,7 @@ JSSRC= \
form/ExpireDate.js \
form/IntegerField.js \
form/TextField.js \
+ form/TextAreaField.js \
form/VlanField.js \
form/DateTimeField.js \
form/Checkbox.js \
diff --git a/src/form/TextAreaField.js b/src/form/TextAreaField.js
new file mode 100644
index 000000000000..3182e4c863be
--- /dev/null
+++ b/src/form/TextAreaField.js
@@ -0,0 +1,60 @@
+Ext.define('Proxmox.form.field.Textareafield', {
+ extend: 'Ext.form.field.TextArea',
+ alias: ['widget.proxmoxtextareafield'],
+
+ config: {
+ skipEmptyText: false,
+ deleteEmpty: false,
+ trimValue: false,
+ editable: true,
+ width: 600,
+ height: 400,
+ scrollable: 'y',
+ },
+
+ setValue: function(value) {
+ // We want to edit the decoded version of the text
+ this.callParent([Proxmox.Utils.base64ToUtf8(value)]);
+ },
+
+ processRawValue: function(value) {
+ // The field could contain multi-line values
+ return Proxmox.Utils.utf8ToBase64(value);
+ },
+
+ getSubmitData: function() {
+ let me = this,
+ data = null,
+ val;
+ if (!me.disabled && me.submitValue && !me.isFileUpload()) {
+ val = me.getSubmitValue();
+ if (val !== null) {
+ data = {};
+ data[me.getName()] = val;
+ } else if (me.getDeleteEmpty()) {
+ data = {};
+ data.delete = me.getName();
+ }
+ }
+ return data;
+ },
+
+ getSubmitValue: function() {
+ let me = this;
+
+ let value = this.processRawValue(this.getRawValue());
+ if (me.getTrimValue() && typeof value === 'string') {
+ value = value.trim();
+ }
+ if (value !== '') {
+ return value;
+ }
+
+ return me.getSkipEmptyText() ? null: value;
+ },
+
+ setAllowBlank: function(allowBlank) {
+ this.allowBlank = allowBlank;
+ this.validate();
+ },
+});
diff --git a/src/grid/ObjectGrid.js b/src/grid/ObjectGrid.js
index b355d6dee2be..30e4ce4b01b6 100644
--- a/src/grid/ObjectGrid.js
+++ b/src/grid/ObjectGrid.js
@@ -182,6 +182,35 @@ Ext.define('Proxmox.grid.ObjectGrid', {
};
},
+ add_textareafield_row: function(name, text, opts) {
+ let me = this;
+
+ opts = opts || {};
+ me.rows = me.rows || {};
+
+ me.rows[name] = {
+ required: true,
+ defaultValue: "",
+ header: text,
+ renderer: function(value) {
+ return Ext.htmlEncode(Proxmox.Utils.base64ToUtf8(value));
+ },
+ editor: {
+ xtype: 'proxmoxWindowEdit',
+ subject: text,
+ onlineHelp: opts.onlineHelp,
+ fieldDefaults: {
+ labelWidth: opts.labelWidth || 600,
+ },
+ items: {
+ xtype: 'proxmoxtextareafield',
+ name: name,
+ },
+ },
+ };
+ },
+
+
editorConfig: {}, // default config passed to editor
run_editor: function() {
--
2.39.2
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-09-13 13:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 13:10 [pbs-devel] [PATCH proxmox{, -backup}/widget-toolkit v4 0/7] fix #5463: add optional consent banner before login Gabriel Goller
2024-09-13 13:10 ` [pbs-devel] [PATCH widget-toolkit v4 1/7] utils: add base64 conversion helper Gabriel Goller
2024-09-17 7:37 ` Thomas Lamprecht
2024-11-26 10:31 ` Gabriel Goller
2024-11-26 11:06 ` Thomas Lamprecht
2024-09-13 13:10 ` [pbs-devel] [PATCH widget-toolkit v4 2/7] window: add consent modal Gabriel Goller
2024-11-25 17:26 ` [pbs-devel] applied: " Thomas Lamprecht
2024-09-13 13:10 ` Gabriel Goller [this message]
2024-11-25 17:26 ` [pbs-devel] applied: [PATCH widget-toolkit v4 3/7] form: add support for multiline textarea Thomas Lamprecht
2024-09-13 13:10 ` [pbs-devel] [PATCH proxmox v4 4/7] rest-server: add custom handlebars escape fn Gabriel Goller
2024-11-25 15:39 ` [pbs-devel] applied: " Thomas Lamprecht
2024-09-13 13:10 ` [pbs-devel] [PATCH proxmox-backup v4 5/7] api: add consent api handler and config option Gabriel Goller
2024-11-25 18:11 ` [pbs-devel] applied: " Thomas Lamprecht
2024-09-13 13:10 ` [pbs-devel] [PATCH proxmox-backup v4 6/7] ui: show consent banner before login Gabriel Goller
2024-11-25 18:12 ` [pbs-devel] applied: " Thomas Lamprecht
2024-11-26 10:01 ` Gabriel Goller
2024-09-13 13:10 ` [pbs-devel] [PATCH proxmox-backup v4 7/7] docs: add section about consent banner Gabriel Goller
2024-11-25 18:13 ` [pbs-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240913131033.396324-4-g.goller@proxmox.com \
--to=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.