[pve-devel] [PATCH storage] api: disks: zfs: enable monthly scrub when creating a pool

[pve-devel] [PATCH storage] api: disks: zfs: enable monthly scrub when creating a pool

[Maximiliano Sandoval]

And disable it when destroying the pool.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---

I think this should be safe to enable by default on a monthly basis. Please tell
me if this is something that should be enabled via a new API parameter.

 src/PVE/API2/Disks/ZFS.pm | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/src/PVE/API2/Disks/ZFS.pm b/src/PVE/API2/Disks/ZFS.pm
index 6fb6bd6b..022710b4 100644
--- a/src/PVE/API2/Disks/ZFS.pm
+++ b/src/PVE/API2/Disks/ZFS.pm
@@ -490,6 +490,13 @@ __PACKAGE__->register_method ({
 		run_command($cmd);
 	    }
 
+	    if (-e '/lib/systemd/system/zfs-scrub-monthly@.timer') {
+		my $scrubtimer = 'zfs-scrub-monthly@'. PVE::Systemd::escape_unit($name, undef) . '.timer';
+		$cmd = ['systemctl', 'enable', $scrubtimer];
+		print "# ", join(' ', @$cmd), "\n";
+		run_command($cmd);
+	    }
+
 	    PVE::Diskmanage::udevadm_trigger($devs->@*);
 
 	    if ($param->{add_storage}) {
@@ -583,6 +590,11 @@ __PACKAGE__->register_method ({
 		    run_command(['systemctl', 'disable', $importunit]);
 		}
 
+		if (-e '/lib/systemd/system/zfs-scrub-monthly@.timer') {
+		    my $scrubtimer = 'zfs-scrub-monthly@' . PVE::Systemd::escape_unit($name) . '.timer';
+		    run_command(['systemctl', 'disable', $scrubtimer]);
+		}
+
 		run_command(['zpool', 'destroy', $name]);
 
 		my $config_err;
-- 
2.39.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel