From: Christoph Heiss <c.heiss@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH installer v3 03/20] low level: run env: ensure `secure_boot` property is dumped as int
Date: Wed, 21 Aug 2024 11:40:05 +0200 [thread overview]
Message-ID: <20240821094023.667806-4-c.heiss@proxmox.com> (raw)
In-Reply-To: <20240821094023.667806-1-c.heiss@proxmox.com>
Previously, in the "false" case, it would serialize to an empty string.
In the future this property will be deserialized by (type-safe) Rust
code.
Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
---
Changes v2 -> v3:
* new patch, found by Aaron
Proxmox/Install/RunEnv.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Proxmox/Install/RunEnv.pm b/Proxmox/Install/RunEnv.pm
index 7eaf96a..13ee8d8 100644
--- a/Proxmox/Install/RunEnv.pm
+++ b/Proxmox/Install/RunEnv.pm
@@ -291,7 +291,7 @@ sub query_installation_environment : prototype() {
log_warn("Failed to read secure boot state: $@\n");
} else {
my @secureboot = unpack("CCCCC", $content);
- $output->{secure_boot} = $secureboot[4] == 1;
+ $output->{secure_boot} = $secureboot[4] == 1 ? 1 : 0;
}
}
--
2.45.2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-08-21 9:41 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-21 9:40 [pve-devel] [PATCH installer v3 00/20] fix #5536: implement post-(auto-)installation notification mechanism Christoph Heiss
2024-08-21 9:40 ` [pve-devel] [PATCH installer v3 01/20] tree-wide: fix some typos Christoph Heiss
2024-08-21 9:40 ` [pve-devel] [PATCH installer v3 02/20] fetch-answer: partition: fix clippy warning Christoph Heiss
2024-08-21 9:40 ` Christoph Heiss [this message]
2024-08-21 9:40 ` [pve-devel] [PATCH installer v3 04/20] common: simplify filesystem type serializing & Display trait impl Christoph Heiss
2024-08-21 9:40 ` [pve-devel] [PATCH installer v3 05/20] common: setup: serialize `target_hd` as string explicitly Christoph Heiss
2024-08-21 9:40 ` [pve-devel] [PATCH installer v3 06/20] common: split out installer setup files loading functionality Christoph Heiss
2024-08-21 9:40 ` [pve-devel] [PATCH installer v3 07/20] common: setup: deserialize `secure_boot` property from runtime env Christoph Heiss
2024-08-21 9:40 ` [pve-devel] [PATCH installer v3 08/20] common: http: pass url by reference Christoph Heiss
2024-08-21 9:40 ` [pve-devel] [PATCH installer v3 09/20] debian: strip unused library dependencies Christoph Heiss
2024-11-10 18:31 ` Thomas Lamprecht
2024-08-21 9:40 ` [pve-devel] [PATCH installer v3 10/20] fetch-answer: move http-related code to gated module in installer-common Christoph Heiss
2024-08-21 9:40 ` [pve-devel] [PATCH installer v3 11/20] tree-wide: convert some more crates to use workspace dependencies Christoph Heiss
2024-08-21 9:40 ` [pve-devel] [PATCH installer v3 12/20] auto-install-assistant: replace `PathBuf` parameters with `AsRef<Path>` Christoph Heiss
2024-08-21 9:40 ` [pve-devel] [PATCH installer v3 13/20] auto-installer: tests: simplify empty disks check Christoph Heiss
2024-08-21 9:40 ` [pve-devel] [PATCH installer v3 14/20] auto-installer: tests: replace `PathBuf` parameters with `AsRef<Path>` Christoph Heiss
2024-08-21 9:40 ` [pve-devel] [PATCH installer v3 15/20] auto-installer: move `SystemDMI` struct to common crate Christoph Heiss
2024-08-21 9:40 ` [pve-devel] [PATCH installer v3 16/20] auto-installer: answer: factor out answer file reading into function Christoph Heiss
2024-08-21 9:40 ` [pve-devel] [PATCH installer v3 17/20] auto-installer: udevinfo: introduce type alias for udev properties Christoph Heiss
2024-08-21 9:40 ` [pve-devel] [PATCH installer v3 18/20] fix #5536: auto-installer: answer: add `posthook` section Christoph Heiss
2024-08-21 9:40 ` [pve-devel] [PATCH installer v3 19/20] fix #5536: post-hook: add utility for sending notifications after auto-install Christoph Heiss
2024-08-21 9:40 ` [pve-devel] [PATCH installer v3 20/20] unconfigured.sh: run proxmox-post-hook after successful auto-install Christoph Heiss
2024-11-10 18:36 ` [pve-devel] partially-applied: [PATCH installer v3 00/20] fix #5536: implement post-(auto-)installation notification mechanism Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240821094023.667806-4-c.heiss@proxmox.com \
--to=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.