From: Christoph Heiss <c.heiss@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 1/2] www: utils: fix `maxcpu` validity check in render_hostcpu()
Date: Wed, 17 Jul 2024 14:49:50 +0200 [thread overview]
Message-ID: <20240717124952.1027784-1-c.heiss@proxmox.com> (raw)
Comparing with Proxmox.Utils.render_cpu() seems just a slight oversight
in the condition. Fix it by aligning it with how it is done in
Proxmox.Utils.render_cpu() for consistency.
Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
---
www/manager6/Utils.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index f5608944d..ddef11bb1 100644
--- a/www/manager6/Utils.js
+++ b/www/manager6/Utils.js
@@ -1073,7 +1073,7 @@ Ext.define('PVE.Utils', {
}
var maxcpu = node.data.maxcpu || 1;
- if (!Ext.isNumeric(maxcpu) && (maxcpu >= 1)) {
+ if (!Ext.isNumeric(maxcpu) || maxcpu < 1) {
return '';
}
--
2.45.1
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2024-07-17 12:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-17 12:49 Christoph Heiss [this message]
2024-07-17 12:49 ` [pve-devel] [PATCH manager 2/2] www: utils: fix inconsistency in host cpu usage display in search view Christoph Heiss
2024-07-17 12:51 ` [pve-devel] [PATCH manager 1/2] www: utils: fix `maxcpu` validity check in render_hostcpu() Christoph Heiss
2024-07-22 16:36 ` [pve-devel] applied-series: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240717124952.1027784-1-c.heiss@proxmox.com \
--to=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.