From: Gabriel Goller <g.goller@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox] readme: add command to satisfy build and regular dependencies
Date: Mon, 15 Jul 2024 11:58:02 +0200 [thread overview]
Message-ID: <20240715095802.6yz63ipdkm5vboqv@luna.proxmox.com> (raw)
In-Reply-To: <20240715090358.189244-1-f.gruenbichler@proxmox.com>
On 15.07.2024 11:03, Fabian Grünbichler wrote:
>this is a common gotcha when starting to work on this repository.
>
>Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
>---
>
>Notes:
> it's a bit rough, and probably a version that parses Cargo.toml instead would
> be even better, but it's better than nothing ;)
>
> README.rst | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
>diff --git a/README.rst b/README.rst
>index 2288f797..bbec9299 100644
>--- a/README.rst
>+++ b/README.rst
>@@ -78,3 +78,26 @@ Some restrictions apply:
> - workspace dependency specifications cannot include ``optional``
> - if needed, the ``optional`` flag needs to be set at the member level when
> using a workspace dependency
>+
>+Installing all required packages
>+================================
>+
>+Generating a source package via debcargo requires all dependencies, including
>+optional ones, being present on the system. The build of that source package
s/being/to be/
is more fitting IMO.
>+does not require all the optional dependencies (since it only tests the default
>+feature set), therefor having all build-dependencies listed in `debian/control`
s/therefor/therefore/
>+installed is not enough to generate the source package.
>+
>+The following command prints a list of all build and regular dependencies
>+listed in a debian/control file, which can be passed to `apt satisfy` to
>+install them:
>+
>+```
>+grep-dctrl -n -s Depends,Build-Depends -S -e '.*' */debian/control \
>+| grep -v '${misc:Depends}' \
>+| sed -e 's/ <!nocheck>//g' -e 's/ (= ${binary:Version})//g' \
>+| sort -u \
>+| sed -e 's/,$//g' \
>+| tr '\n' ',' \
>+| sed -e 's/,$//' -e 's/^,//g'
>+```
Otherwise tested the command, it works great!
A small cosmetic nit though:
sed -e 's/,$/\n/' -e 's/^,//g
So that we have a new line after the last element.
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2024-07-15 9:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-15 9:03 Fabian Grünbichler
2024-07-15 9:58 ` Gabriel Goller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240715095802.6yz63ipdkm5vboqv@luna.proxmox.com \
--to=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.