all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Markus Frank <m.frank@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH qemu-server v11 7/12] disable snapshot (with RAM) and hibernate with virtio-fs devices
Date: Mon,  8 Jul 2024 15:55:06 +0200	[thread overview]
Message-ID: <20240708135511.1083400-8-m.frank@proxmox.com> (raw)
In-Reply-To: <20240708135511.1083400-1-m.frank@proxmox.com>

Signed-off-by: Markus Frank <m.frank@proxmox.com>
---
 PVE/API2/Qemu.pm  | 6 ++++++
 PVE/QemuServer.pm | 4 ++++
 2 files changed, 10 insertions(+)

diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index f4982b0..854ad98 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2/Qemu.pm
@@ -5246,6 +5246,12 @@ __PACKAGE__->register_method({
 
 	my $snapname = extract_param($param, 'snapname');
 
+	# TODO: move to check_non_migratable_resources when applied (SEV patch series)
+	my $vmconf = PVE::QemuConfig->load_config($vmid);
+	my $vmstate = extract_param($param, 'vmstate');
+	die "Cannot snapshot with including state while virtiofs is in use.\n"
+	    if $vmstate && PVE::QemuServer::Virtiofs::virtiofs_enabled($vmconf);
+
 	die "unable to use snapshot name 'current' (reserved name)\n"
 	    if $snapname eq 'current';
 
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 026fb66..d48d0a6 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -6393,6 +6393,10 @@ sub vm_suspend {
 
 	$conf = PVE::QemuConfig->load_config($vmid);
 
+	# TODO: move to check_non_migratable_resources when applied (SEV patch series)
+	die "Cannot hibernate while virtiofs is in use.\n"
+	    if $includestate && PVE::QemuServer::Virtiofs::virtiofs_enabled($conf);
+
 	my $is_backing_up = PVE::QemuConfig->has_lock($conf, 'backup');
 	PVE::QemuConfig->check_lock($conf)
 	    if !($skiplock || $is_backing_up);
-- 
2.39.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  parent reply	other threads:[~2024-07-08 13:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-08 13:54 [pve-devel] [PATCH cluster/guest-common/docs/qemu-server/manager v11 0/12] virtiofs Markus Frank
2024-07-08 13:55 ` [pve-devel] [PATCH cluster v11 1/12] add mapping/dir.cfg for resource mapping Markus Frank
2024-07-08 13:55 ` [pve-devel] [PATCH guest-common v11 2/12] add dir mapping section config Markus Frank
2024-07-08 13:55 ` [pve-devel] [PATCH docs v11 3/12] add doc section for the shared filesystem virtio-fs Markus Frank
2024-07-08 13:55 ` [pve-devel] [PATCH qemu-server v11 4/12] control: add virtiofsd as runtime dependency for qemu-server Markus Frank
2024-07-08 13:55 ` [pve-devel] [PATCH qemu-server v11 5/12] fix #1027: virtio-fs support Markus Frank
2024-07-08 13:55 ` [pve-devel] [PATCH qemu-server v11 6/12] migration: check_local_resources for virtiofs Markus Frank
2024-07-08 13:55 ` Markus Frank [this message]
2024-07-08 13:55 ` [pve-devel] [PATCH manager v11 08/12] api: add resource map api endpoints for directories Markus Frank
2024-07-08 13:55 ` [pve-devel] [PATCH manager v11 09/12] ui: add edit window for dir mappings Markus Frank
2024-07-08 13:55 ` [pve-devel] [PATCH manager v11 10/12] ui: add resource mapping view for directories Markus Frank
2024-07-08 13:55 ` [pve-devel] [PATCH manager v11 11/12] ui: form: add selector for directory mappings Markus Frank
2024-07-08 13:55 ` [pve-devel] [PATCH manager v11 12/12] ui: add options to add virtio-fs to qemu config Markus Frank

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240708135511.1083400-8-m.frank@proxmox.com \
    --to=m.frank@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal