all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Lukas Wagner <l.wagner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve-guest-common v8 01/13] vzdump: common: allow 'job-id' as a parameter without being in schema
Date: Fri,  5 Jul 2024 15:46:39 +0200	[thread overview]
Message-ID: <20240705134651.296607-2-l.wagner@proxmox.com> (raw)
In-Reply-To: <20240705134651.296607-1-l.wagner@proxmox.com>

'job-id' is passed when a backup as started as a job and will be
passed to the notification system as matchable metadata. It it
can be considered 'internal'.

Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
 src/PVE/VZDump/Common.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PVE/VZDump/Common.pm b/src/PVE/VZDump/Common.pm
index 1996c5b..2532b42 100644
--- a/src/PVE/VZDump/Common.pm
+++ b/src/PVE/VZDump/Common.pm
@@ -503,7 +503,7 @@ sub command_line {
 
     foreach my $p (keys %$param) {
 	next if $p eq 'id' || $p eq 'vmid' || $p eq 'starttime' ||
-	        $p eq 'dow' || $p eq 'stdout' || $p eq 'enabled';
+	        $p eq 'dow' || $p eq 'stdout' || $p eq 'enabled' || $p eq 'job-id';
 	my $v = $param->{$p};
 	my $pd = $confdesc->{$p} || die "no such vzdump option '$p'\n";
 	if ($p eq 'exclude-path') {
-- 
2.39.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2024-07-05 13:47 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-05 13:46 [pve-devel] [PATCH many v8 00/13] notifications: notification metadata matching improvements Lukas Wagner
2024-07-05 13:46 ` Lukas Wagner [this message]
2024-07-05 13:46 ` [pve-devel] [PATCH manager v8 02/13] api: jobs: vzdump: pass job 'job-id' parameter Lukas Wagner
2024-07-05 13:46 ` [pve-devel] [PATCH manager v8 03/13] ui: dc: backup: allow to set custom job id in advanced settings Lukas Wagner
2024-07-05 13:46 ` [pve-devel] [PATCH manager v8 04/13] api: notification: add API for getting known metadata fields/values Lukas Wagner
2024-07-05 13:46 ` [pve-devel] [PATCH manager v8 05/13] ui: utils: add overrides for translatable notification fields/values Lukas Wagner
2024-07-05 13:46 ` [pve-devel] [PATCH manager v8 06/13] d/control: bump proxmox-widget-toolkit dependency to 4.1.4 Lukas Wagner
2024-07-05 13:46 ` [pve-devel] [PATCH widget-toolkit v8 07/13] notification: matcher: match-field: show known fields/values Lukas Wagner
2024-07-05 13:46 ` [pve-devel] [PATCH widget-toolkit v8 08/13] notification: matcher: move match-field formulas to local viewModel Lukas Wagner
2024-07-05 13:46 ` [pve-devel] [PATCH widget-toolkit v8 09/13] notification: matcher: move match-calendar fields to panel Lukas Wagner
2024-07-05 13:46 ` [pve-devel] [PATCH widget-toolkit v8 10/13] notification: matcher: move match-severity " Lukas Wagner
2024-07-05 13:46 ` [pve-devel] [PATCH docs v8 11/13] notifications: describe new notification metadata fields Lukas Wagner
2024-07-05 13:46 ` [pve-devel] [PATCH docs v8 12/13] notifications: match-field 'exact'-mode can now match multiple values Lukas Wagner
2024-07-05 13:46 ` [pve-devel] [PATCH docs v8 13/13] notifications: add note regarding when 'job-id' is set for backups Lukas Wagner
2024-07-08  8:12 ` [pve-devel] [PATCH many v8 00/13] notifications: notification metadata matching improvements Max Carrara
2024-07-08  9:37   ` Lukas Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240705134651.296607-2-l.wagner@proxmox.com \
    --to=l.wagner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal