From: Gabriel Goller <g.goller@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox{, -backup} v4 0/4] output full anyhow context in client
Date: Tue, 18 Jun 2024 16:21:59 +0200 [thread overview]
Message-ID: <20240618142207.331674-1-g.goller@proxmox.com> (raw)
Instead of using format_err! and format! to create error messages, we
want to move to anyhow::Context and add information to already
existing anyhow::Error's.
Before we start to gradually phase out the format! error calls, we
need to print the whole context + error, because the default
anyhow::Error Display implementation doesn't print the actual error.
This series starts with the proxmox-backup-client and includes a patch
from Fabian that introduces pretty-printing of errors (including
the context) and some other high-level stuff from me. The scope
is not to remove every format call and add a context everywhere,
but to enable this change in the future.
v4:
- inlined eprintln's arguments
- removed readme.rst (to be moved to the Developer Documentation)
v3:
- rebased
- applied Max's fixup
v2:
- moved explanation to readme.rst file
- remove unwrap, use take() in `if let`
- cargo fmt
proxmox:
Gabriel Goller (1):
CLI: print fatal errors including causes
proxmox-router/src/cli/command.rs | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
proxmox-backup:
Gabriel Goller (3):
pxar: remove ArchiveError
pxar: add UniqueContext helper
pxar: use anyhow::Error in PxarBackupStream
pbs-client/src/pxar/create.rs | 48 +++++++++++++---------------
pbs-client/src/pxar_backup_stream.rs | 18 +++++------
2 files changed, 32 insertions(+), 34 deletions(-)
Summary over all repositories:
3 files changed, 34 insertions(+), 36 deletions(-)
--
Generated by git-murpp 0.5.0
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next reply other threads:[~2024-06-18 14:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 14:21 Gabriel Goller [this message]
2024-06-18 14:22 ` [pbs-devel] [PATCH proxmox v4 1/4] CLI: print fatal errors including causes Gabriel Goller
2024-06-18 14:22 ` [pbs-devel] [PATCH proxmox-backup v4 2/4] pxar: remove ArchiveError Gabriel Goller
2024-06-18 14:22 ` [pbs-devel] [PATCH proxmox-backup v4 3/4] pxar: add UniqueContext helper Gabriel Goller
2024-06-18 14:22 ` [pbs-devel] [PATCH proxmox-backup v4 4/4] pxar: use anyhow::Error in PxarBackupStream Gabriel Goller
2024-06-19 9:36 ` [pbs-devel] applied-series: [PATCH proxmox{, -backup} v4 0/4] output full anyhow context in client Wolfgang Bumiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240618142207.331674-1-g.goller@proxmox.com \
--to=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.