[pve-devel] [PATCH manager v2 1/3] ui: homogenize uses of Zstd and SCSI

[pve-devel] [PATCH manager v2 1/3] ui: homogenize uses of Zstd and SCSI

[Maximiliano Sandoval]

See [1, 2] for their spelling.

[1] https://en.wikipedia.org/wiki/Zstd
[2] https://en.wikipedia.org/wiki/SCSI

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
Differences from v2:
- Fix commit history
- Remove last commit

 www/manager6/form/BackupCompressionSelector.js | 2 +-
 www/manager6/panel/BackupAdvancedOptions.js    | 2 +-
 www/manager6/window/DownloadUrlToStorage.js    | 2 +-
 www/manager6/window/GuestImport.js             | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/www/manager6/form/BackupCompressionSelector.js b/www/manager6/form/BackupCompressionSelector.js
index 014b8f7e..2efc2919 100644
--- a/www/manager6/form/BackupCompressionSelector.js
+++ b/www/manager6/form/BackupCompressionSelector.js
@@ -5,6 +5,6 @@ Ext.define('PVE.form.BackupCompressionSelector', {
                 ['0', Proxmox.Utils.noneText],
                 ['lzo', 'LZO (' + gettext('fast') + ')'],
                 ['gzip', 'GZIP (' + gettext('good') + ')'],
-                ['zstd', 'ZSTD (' + gettext('fast and good') + ')'],
+                ['zstd', 'Zstd (' + gettext('fast and good') + ')'],
     ],
 });
diff --git a/www/manager6/panel/BackupAdvancedOptions.js b/www/manager6/panel/BackupAdvancedOptions.js
index 7dd19f96..e6c951e2 100644
--- a/www/manager6/panel/BackupAdvancedOptions.js
+++ b/www/manager6/panel/BackupAdvancedOptions.js
@@ -150,7 +150,7 @@ Ext.define('PVE.panel.BackupAdvancedOptions', {
 	    endFlex: 2,
 	    endColumn: {
 		xtype: 'displayfield',
-		value: `${gettext('Threads used for zstd compression (non-PBS).')} ${Ext.String.format(gettext("Schema default: {0}"), 1)}`,
+		value: `${gettext('Threads used for Zstd compression (non-PBS).')} ${Ext.String.format(gettext("Schema default: {0}"), 1)}`,
 	    },
 	},
 	{
diff --git a/www/manager6/window/DownloadUrlToStorage.js b/www/manager6/window/DownloadUrlToStorage.js
index 5523a152..f165e3a9 100644
--- a/www/manager6/window/DownloadUrlToStorage.js
+++ b/www/manager6/window/DownloadUrlToStorage.js
@@ -227,7 +227,7 @@ Ext.define('PVE.window.DownloadUrlToStorage', {
 				['__default__', Proxmox.Utils.NoneText],
 				['lzo', 'LZO'],
 				['gz', 'GZIP'],
-				['zst', 'ZSTD'],
+				['zst', 'Zstd'],
 		    ],
 		    cbind: {
 			hidden: get => get('content') !== 'iso',
diff --git a/www/manager6/window/GuestImport.js b/www/manager6/window/GuestImport.js
index 4bedc211..b9dc44b8 100644
--- a/www/manager6/window/GuestImport.js
+++ b/www/manager6/window/GuestImport.js
@@ -930,7 +930,7 @@ Ext.define('PVE.window.GuestImport', {
 	    const warningsCatalogue = {
 		'cdrom-image-ignored': gettext("CD-ROM images cannot get imported, if required you can reconfigure the '{0}' drive in the 'Advanced' tab."),
 		'nvme-unsupported': gettext("NVMe disks are currently not supported, '{0}' will get attaced as SCSI"),
-		'ovmf-with-lsi-unsupported': gettext("OVMF is built without LSI drivers, scsi hardware was set to '{1}'"),
+		'ovmf-with-lsi-unsupported': gettext("OVMF is built without LSI drivers, SCSI hardware was set to '{1}'"),
 		'serial-port-socket-only': gettext("Serial socket '{0}' will be mapped to a socket"),
 		'guest-is-running': gettext('Virtual guest seems to be running on source host. Import might fail or have inconsistent state!'),
 		'efi-state-lost': Ext.String.format(
-- 
2.39.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH manager v2 2/3] ui: guest import: fix typo on 'attached'

[Maximiliano Sandoval]

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 www/manager6/window/GuestImport.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/window/GuestImport.js b/www/manager6/window/GuestImport.js
index b9dc44b8..376a0e35 100644
--- a/www/manager6/window/GuestImport.js
+++ b/www/manager6/window/GuestImport.js
@@ -929,7 +929,7 @@ Ext.define('PVE.window.GuestImport', {
 	let renderWarning = w => {
 	    const warningsCatalogue = {
 		'cdrom-image-ignored': gettext("CD-ROM images cannot get imported, if required you can reconfigure the '{0}' drive in the 'Advanced' tab."),
-		'nvme-unsupported': gettext("NVMe disks are currently not supported, '{0}' will get attaced as SCSI"),
+		'nvme-unsupported': gettext("NVMe disks are currently not supported, '{0}' will get attached as SCSI"),
 		'ovmf-with-lsi-unsupported': gettext("OVMF is built without LSI drivers, SCSI hardware was set to '{1}'"),
 		'serial-port-socket-only': gettext("Serial socket '{0}' will be mapped to a socket"),
 		'guest-is-running': gettext('Virtual guest seems to be running on source host. Import might fail or have inconsistent state!'),
-- 
2.39.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH manager v2 3/3] ui: backup job: inline translatable string

[Maximiliano Sandoval]

This provides translators context of what kind of noun goes before
'Threads'. The word Zstd is already in other translations.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 www/manager6/panel/BackupAdvancedOptions.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/panel/BackupAdvancedOptions.js b/www/manager6/panel/BackupAdvancedOptions.js
index e6c951e2..fed1d0a7 100644
--- a/www/manager6/panel/BackupAdvancedOptions.js
+++ b/www/manager6/panel/BackupAdvancedOptions.js
@@ -135,7 +135,7 @@ Ext.define('PVE.panel.BackupAdvancedOptions', {
 		xtype: 'proxmoxintegerfield',
 		name: 'zstd',
 		reference: 'zstdThreadCount',
-		fieldLabel: Ext.String.format(gettext('{0} Threads'), 'Zstd'),
+		fieldLabel: gettext('Zstd Threads'),
 		fieldStyle: 'text-align: right',
 		emptyText: gettext('Fallback'),
 		minValue: 0,
-- 
2.39.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel