From: Gabriel Goller <g.goller@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH widget-toolkit/proxmox{, -backup} v3 0/7] fix #5463: add optional consent banner before login
Date: Fri, 7 Jun 2024 13:48:31 +0200 [thread overview]
Message-ID: <20240607114846.321729-1-g.goller@proxmox.com> (raw)
The consent text is stored in the node.cfg config file and is encoded
using base64. This allows us to support multi-line strings and special
characters. To easily edit the text a new edit-field called
ProxmoxTextAreaField has been introduced. It supports editing and saving
multi-line text and converting it to its base64 representation.
The same implementation will be ported to pve and eventually pmg in
the foreseeable future.
v3, thanks @Dominik, @Thomas:
- store text with base64 instead of URI-encoding
- improve content popup sizing
- support markdown
v2, thanks @Thomas, @Dominik:
- remove consent.txt file, move to node.cfg config
- add ui option to insert consent text
- encode text with encodeURI/decodeURI
v1, thanks @Dominik:
- embed consent text into index.html file instead of extra api request
- removed decline button
- added alwaysOnTop property to popup
widget-toolkit:
Gabriel Goller (3):
utils: add base64 conversion helper
window: add consent modal
form: add support for multiline textarea
src/Makefile | 2 ++
src/Utils.js | 18 ++++++++++++
src/form/TextAreaField.js | 60 ++++++++++++++++++++++++++++++++++++++
src/grid/ObjectGrid.js | 29 ++++++++++++++++++
src/window/ConsentModal.js | 36 +++++++++++++++++++++++
5 files changed, 145 insertions(+)
create mode 100644 src/form/TextAreaField.js
create mode 100644 src/window/ConsentModal.js
proxmox:
Gabriel Goller (1):
rest-server: add custom handlebars escape fn
proxmox-rest-server/src/api_config.rs | 28 ++++++++++++++++++++++++++-
1 file changed, 27 insertions(+), 1 deletion(-)
proxmox-backup:
Gabriel Goller (3):
api: add consent api handler and config option
ui: show consent banner before login
docs: add section about consent banner
docs/gui.rst | 8 ++++++++
src/api2/node/config.rs | 8 ++++++++
src/bin/proxmox-backup-proxy.rs | 11 ++++++++---
src/config/node.rs | 4 ++++
www/LoginView.js | 12 ++++++++++++
www/config/NodeOptionView.js | 6 ++++++
www/index.hbs | 1 +
7 files changed, 47 insertions(+), 3 deletions(-)
Summary over all repositories:
13 files changed, 219 insertions(+), 4 deletions(-)
--
Generated by git-murpp 0.5.0
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next reply other threads:[~2024-06-07 11:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-07 11:48 Gabriel Goller [this message]
2024-06-07 11:48 ` [pbs-devel] [PATCH widget-toolkit v3 1/7] utils: add base64 conversion helper Gabriel Goller
2024-06-07 11:48 ` [pbs-devel] [PATCH widget-toolkit v3 2/7] window: add consent modal Gabriel Goller
2024-06-07 11:48 ` [pbs-devel] [PATCH widget-toolkit v3 3/7] form: add support for multiline textarea Gabriel Goller
2024-06-07 11:48 ` [pbs-devel] [PATCH proxmox v3 4/7] rest-server: add custom handlebars escape fn Gabriel Goller
2024-06-07 11:48 ` [pbs-devel] [PATCH proxmox-backup v3 5/7] api: add consent api handler and config option Gabriel Goller
2024-06-07 11:48 ` [pbs-devel] [PATCH proxmox-backup v3 6/7] ui: show consent banner before login Gabriel Goller
2024-06-07 11:48 ` [pbs-devel] [PATCH proxmox-backup v3 7/7] docs: add section about consent banner Gabriel Goller
2024-09-13 13:10 ` [pbs-devel] [PATCH widget-toolkit/proxmox{, -backup} v3 0/7] fix #5463: add optional consent banner before login Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240607114846.321729-1-g.goller@proxmox.com \
--to=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.