From: Gabriel Goller <g.goller@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox{, -backup} v7 0/2] close #4763: client: add command to forget backup group
Date: Mon, 3 Jun 2024 10:43:09 +0200 [thread overview]
Message-ID: <20240603084316.64361-1-g.goller@proxmox.com> (raw)
Add the command `proxmox-backup-client group forget <group>` so
that we can forget (delete) whole groups with all the containing
snapshots. As this is quite dangerous, we added a prompt, so the
user has to confirm the operation.
v7, thanks @Wolfgang:
- style nit: return unit type on success in api fn
- let `Confirmation` impl Clone, Copy, and Eq as well
- with Copy we can let the fn's consume self
- organize imports
v6, thanks @Thomas:
- add more generic confirmation helper drawn up by @Thomas
- stricter yes/no matching with default
v5, thanks @Christian:
- stricter input matching ($ in regex)
- avoid printing full datastore path
v4:
- removed localization
--version 3 has been skipped--
v2:
- added localization
proxmox:
Gabriel Goller (1):
router: cli: add confirmation helper
proxmox-router/Cargo.toml | 1 +
proxmox-router/src/cli/mod.rs | 114 +++++++++++++++++++++++++++++++++-
2 files changed, 114 insertions(+), 1 deletion(-)
proxmox-backup:
Gabriel Goller (1):
close #4763: client: add command to forget backup group
proxmox-backup-client/src/group.rs | 88 ++++++++++++++++++++++++++++++
proxmox-backup-client/src/main.rs | 3 +
2 files changed, 91 insertions(+)
create mode 100644 proxmox-backup-client/src/group.rs
Summary over all repositories:
4 files changed, 205 insertions(+), 1 deletions(-)
--
Generated by git-murpp 0.5.0
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next reply other threads:[~2024-06-03 8:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-03 8:43 Gabriel Goller [this message]
2024-06-03 8:43 ` [pbs-devel] [PATCH proxmox v7 1/2] router: cli: add confirmation helper Gabriel Goller
2024-06-03 8:43 ` [pbs-devel] [PATCH proxmox-backup v7 2/2] close #4763: client: add command to forget backup group Gabriel Goller
2024-06-19 9:37 ` [pbs-devel] applied-series: [PATCH proxmox{, -backup} v7 0/2] " Wolfgang Bumiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240603084316.64361-1-g.goller@proxmox.com \
--to=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.