all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pbs-devel] [PATCH proxmox-backup] tape: mam: actually enforcing the length when writing attributes
@ 2024-05-23 10:08 Dominik Csapak
  2024-05-24  7:50 ` Thomas Lamprecht
  0 siblings, 1 reply; 4+ messages in thread
From: Dominik Csapak @ 2024-05-23 10:08 UTC (permalink / raw)
  To: pbs-devel

we have to check against the length of the attribute, not the u16
maximum value.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 pbs-tape/src/sg_tape/mam.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pbs-tape/src/sg_tape/mam.rs b/pbs-tape/src/sg_tape/mam.rs
index 4e995d0b..dc5163a5 100644
--- a/pbs-tape/src/sg_tape/mam.rs
+++ b/pbs-tape/src/sg_tape/mam.rs
@@ -169,7 +169,7 @@ pub fn write_mam_attribute<F: AsRawFd>(
     attr_data.extend(data);
     if !data.is_empty() && data.len() < attribute.len as usize {
         attr_data.resize(attr_data.len() - data.len() + attribute.len as usize, 0);
-    } else if data.len() > u16::MAX as usize {
+    } else if data.len() > attribute.len as usize {
         bail!("data to long");
     }
 
-- 
2.39.2



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-05-24  8:26 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-23 10:08 [pbs-devel] [PATCH proxmox-backup] tape: mam: actually enforcing the length when writing attributes Dominik Csapak
2024-05-24  7:50 ` Thomas Lamprecht
2024-05-24  8:19   ` Dominik Csapak
2024-05-24  8:26     ` Thomas Lamprecht

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal