From: Gabriel Goller <g.goller@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [RFC backup/proxmox-backup 0/4] fix #5463: add optional consent banner before login
Date: Thu, 16 May 2024 18:24:57 +0200 [thread overview]
Message-ID: <20240516162508.327472-1-g.goller@proxmox.com> (raw)
This has been requested many times already for all products. To keep
it simple as it's still quite a niche feature, works with a single file:
/etc/proxmox-backup/consent.txt. If the file exists and is not empty,
a consent banner will be shown in front of the login view.
This is just a reference implementation for pbs to get some feedback
and check if my general approach is alright. The same implementation
will then be ported to pve and eventually pmg.
Another disclaimer: IANAL (I am not a lawyer :) ), so the wording is
probably off. I also have my doubts about the behavior when the user
clicks "I decline", maybe we should completely exit the page?.
widget-toolkit:
Gabriel Goller (3):
api: add consent api handler and config
ui: show consent banner before login
docs: add short section about consent banner
docs/gui.rst | 7 +++++++
src/api2/access/consent.rs | 25 +++++++++++++++++++++++++
src/api2/access/mod.rs | 2 ++
src/config/consent.rs | 11 +++++++++++
src/config/mod.rs | 1 +
www/LoginView.js | 14 ++++++++++++++
6 files changed, 60 insertions(+)
create mode 100644 src/api2/access/consent.rs
create mode 100644 src/config/consent.rs
backup:
Gabriel Goller (1):
window: add consent modal
src/Makefile | 1 +
src/window/ConsentModal.js | 39 ++++++++++++++++++++++++++++++++++++++
2 files changed, 40 insertions(+)
create mode 100644 src/window/ConsentModal.js
Summary over all repositories:
8 files changed, 100 insertions(+), 0 deletions(-)
--
Generated by git-murpp 0.5.0
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next reply other threads:[~2024-05-16 16:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-16 16:24 Gabriel Goller [this message]
2024-05-16 16:24 ` [pbs-devel] [PATCH proxmox-backup 1/4] api: add consent api handler and config Gabriel Goller
2024-05-16 16:24 ` [pbs-devel] [PATCH proxmox-backup 2/4] ui: show consent banner before login Gabriel Goller
2024-05-16 16:25 ` [pbs-devel] [PATCH proxmox-backup 3/4] docs: add short section about consent banner Gabriel Goller
2024-05-16 16:25 ` [pbs-devel] [PATCH backup 4/4] window: add consent modal Gabriel Goller
2024-05-17 7:15 ` [pbs-devel] [RFC backup/proxmox-backup 0/4] fix #5463: add optional consent banner before login Dominik Csapak
2024-05-21 8:22 ` Gabriel Goller
2024-05-21 8:35 ` Dominik Csapak
2024-05-21 10:13 ` Gabriel Goller
2024-05-22 13:28 ` Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240516162508.327472-1-g.goller@proxmox.com \
--to=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.