From: Stefan Hanreich <s.hanreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH proxmox-firewall v2 1/1] firewall: properly reject ipv6 traffic
Date: Mon, 13 May 2024 14:14:25 +0200 [thread overview]
Message-ID: <20240513121425.253019-1-s.hanreich@proxmox.com> (raw)
ICMPv6 has different message types for rejecting traffic. With ICMP we
used host-prohibited as rejection type, which doesn't exist in ICMPv6.
Add an additional rule for IPv6, so it uses admin-prohibited.
Additionally, add a terminal drop statement in order to prevent any
traffic that does not get matched from bypassing the reject chain.
Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---
Changes from v1 -> v2:
* add a terminal drop statement to prevent any unmatched traffic from
bypassing the reject chain
* properly match ICMPv6 traffic via l4proto
proxmox-firewall/resources/proxmox-firewall.nft | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/proxmox-firewall/resources/proxmox-firewall.nft b/proxmox-firewall/resources/proxmox-firewall.nft
index f36bf3b..f60f8b5 100644
--- a/proxmox-firewall/resources/proxmox-firewall.nft
+++ b/proxmox-firewall/resources/proxmox-firewall.nft
@@ -75,8 +75,10 @@ table inet proxmox-firewall {
ip saddr 224.0.0.0/4 drop
meta l4proto tcp reject with tcp reset
- meta l4proto icmp reject with icmp type port-unreachable
+ meta l4proto { icmp, ipv6-icmp } reject with icmpx type port-unreachable
reject with icmp type host-prohibited
+ reject with icmpv6 type admin-prohibited
+ drop
}
set v4-dc/management {
@@ -289,8 +291,10 @@ table bridge proxmox-firewall-guests {
ip saddr 224.0.0.0/4 drop
meta l4proto tcp reject with tcp reset
- meta l4proto icmp reject with icmp type port-unreachable
+ meta l4proto { icmp, ipv6-icmp } reject with icmpx type port-unreachable
reject with icmp type host-prohibited
+ reject with icmpv6 type admin-prohibited
+ drop
}
chain after-vm-in {
--
2.39.2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2024-05-13 12:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-13 12:14 Stefan Hanreich [this message]
2024-05-21 13:46 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240513121425.253019-1-s.hanreich@proxmox.com \
--to=s.hanreich@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.