From: Christoph Heiss <c.heiss@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH installer v2 0/4] assistant: clean up glob patterns & regexes
Date: Mon, 13 May 2024 11:49:08 +0200 [thread overview]
Message-ID: <20240513094936.412650-1-c.heiss@proxmox.com> (raw)
The proxmox-auto-install-assistant uses
- glob patterns for disk matching, which can be pre-compiled for
efficiency
- regexes for udev property matching, which can be simplified by some
simple prefix matching & splitting on =
The latter also significantly reduces binary size due to the removing
the regex dependency, for details see patch #4.
Overall no functional changes in this series.
v1: https://lists.proxmox.com/pipermail/pve-devel/2024-May/063802.html
Changes v1 -> v2:
* rebased on latest master
Christoph Heiss (4):
tree-wide: run rustfmt, fix clippy warnings
assistant: drop unused `log` dependency
assistant: pre-compile ignored block device patterns
assistant: avoid regex for simple prefix matching
proxmox-auto-install-assistant/Cargo.toml | 2 -
proxmox-auto-install-assistant/src/main.rs | 75 ++++++++-----------
proxmox-auto-installer/tests/parse-answer.rs | 14 ++--
.../src/fetch_plugins/partition.rs | 10 +--
4 files changed, 45 insertions(+), 56 deletions(-)
--
2.44.0
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2024-05-13 9:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-13 9:49 Christoph Heiss [this message]
2024-05-13 9:49 ` [pve-devel] [PATCH installer v2 1/4] tree-wide: run rustfmt, fix clippy warnings Christoph Heiss
2024-05-13 9:49 ` [pve-devel] [PATCH installer v2 2/4] assistant: drop unused `log` dependency Christoph Heiss
2024-05-13 9:49 ` [pve-devel] [PATCH installer v2 3/4] assistant: pre-compile ignored block device patterns Christoph Heiss
2024-11-12 19:55 ` [pve-devel] applied: " Thomas Lamprecht
2024-05-13 9:49 ` [pve-devel] [PATCH installer v2 4/4] assistant: avoid regex for simple prefix matching Christoph Heiss
2024-05-13 11:15 ` [pve-devel] [PATCH installer v2 0/4] assistant: clean up glob patterns & regexes Aaron Lauterer
2024-06-17 7:11 ` Christoph Heiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240513094936.412650-1-c.heiss@proxmox.com \
--to=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.