all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve-esxi-import-tools/storage v2] improve error handling/logging
Date: Fri, 10 May 2024 15:56:56 +0200	[thread overview]
Message-ID: <20240510135658.3519714-1-d.csapak@proxmox.com> (raw)

two smaller patches that improve which error gets shown to the user and
logged to syslog in case of an early error when trying to fuse mount

changes from v1:
* improved commit message
* remove superfluous space in error
* split 'open_file' into its own line
* reworded context messages
* removed (de)reference operator
* removed unnecessary comment
* removed unnecessary context adds (inside the functions is enough context)

pve-esxi-import-tools:

Dominik Csapak (1):
  improve error handling before mounting

 src/esxi.rs |  7 ++++++-
 src/main.rs | 15 +++++++++++----
 2 files changed, 17 insertions(+), 5 deletions(-)

pve-storage:

Dominik Csapak (1):
  esxi: improve error handling for fuse mount tool

 src/PVE/Storage/ESXiPlugin.pm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

-- 
2.39.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


             reply	other threads:[~2024-05-10 13:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-10 13:56 Dominik Csapak [this message]
2024-05-10 13:56 ` [pve-devel] [PATCH pve-esxi-import-tools v2 1/1] improve error handling before mounting Dominik Csapak
2024-05-10 13:56 ` [pve-devel] [PATCH storage v2 1/1] esxi: improve error handling for fuse mount tool Dominik Csapak
2024-06-07 11:27 ` [pve-devel] applied: [PATCH pve-esxi-import-tools/storage v2] improve error handling/logging Wolfgang Bumiller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240510135658.3519714-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal