[pve-devel] [PATCH qemu-server] schema: fix description of migrate_downtime parameter

[pve-devel] [PATCH qemu-server] schema: fix description of migrate_downtime parameter

[Fiona Ebner]

Since commit 865ef132 ("implement dynamic migration_downtime") the
migration downtime will be automatically increased when migration
cannot converge at the very end. Update the description to reflect
reality.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 PVE/QemuServer.pm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 82e7d6a6..9032d294 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -590,7 +590,10 @@ EODESCR
     migrate_downtime => {
 	optional => 1,
 	type => 'number',
-	description => "Set maximum tolerated downtime (in seconds) for migrations.",
+	description => "Set maximum tolerated downtime (in seconds) for migrations. Should the"
+	    ." migration not be able to converge in the very end, because too much newly dirtied"
+	    ." RAM needs to be transferred, the limit will be increased automatically step-by-step"
+	    ." until migration can converge.",
 	minimum => 0,
 	default => 0.1,
     },
-- 
2.39.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH qemu-server] schema: fix description of migrate_downtime parameter

[Thomas Lamprecht]

On 03/05/2024 14:01, Fiona Ebner wrote:
> Since commit 865ef132 ("implement dynamic migration_downtime") the
> migration downtime will be automatically increased when migration
> cannot converge at the very end. Update the description to reflect
> reality.
> 
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>  PVE/QemuServer.pm | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
>

applied, thanks! we might deprecate this option then, as a user cannot
force a minimal downtime anyway anymore through it, and not sure how
much use it has to set the initial value.

Deprecating would for now mostly mean adding that word to the description
though, so no biggie.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] applied: [PATCH qemu-server] schema: fix description of migrate_downtime parameter

[Fiona Ebner]

Am 03.05.24 um 19:36 schrieb Thomas Lamprecht:
> On 03/05/2024 14:01, Fiona Ebner wrote:
>> Since commit 865ef132 ("implement dynamic migration_downtime") the
>> migration downtime will be automatically increased when migration
>> cannot converge at the very end. Update the description to reflect
>> reality.
>>
>> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
>> ---
>>  PVE/QemuServer.pm | 5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>
>>
> 
> applied, thanks! we might deprecate this option then, as a user cannot
> force a minimal downtime anyway anymore through it, and not sure how
> much use it has to set the initial value.
> 

If the network is fast enough, the option can still be useful, because
then the downtime will be effectively shorter (than our default).
Another idea would be to make it a property string and allow setting
enforce=true (or auto-increase=false). See the related discussion here:
https://forum.proxmox.com/threads/146237/post-660507

> Deprecating would for now mostly mean adding that word to the description
> though, so no biggie.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel