From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH-SERIES qemu-server/manager] fix #5440: HMP/disk timeout improvements
Date: Fri, 3 May 2024 13:19:49 +0200 [thread overview]
Message-ID: <20240503111956.46543-1-f.ebner@proxmox.com> (raw)
Currently, all HMP commands (issued as a "human-monitor-command" QMP
command) use the default timeout for QMP commands of just 5 seconds.
For drive-related commands, this is not always enough, as reported in
bug #5440. Other drive-related QMP commands use 10 minutes, so it is
natural to increase the limit for the HMP command for detaching a
drive to that too.
Other HMP commands that are issued are limited by being in a
synchronous API call or interactive monitor session, but can still
benefit from an increased timeout over the 5 second default.
Lastly, the UI is adapted to use the asynchronous API call when
hot-unplugging a drive, to be more in-line with the backend.
qemu-server:
Fiona Ebner (5):
monitor: allow passing timeout for a HMP command
api: human monitor: increase timeout to 25 seconds
vzdump: increase timeout for attaching drives to 60 seconds
cli: qm: increase timeout for monitor commands to 30 seconds
fix #5440: hmp helpers: drive{add,del}: increase timeout
PVE/API2/Qemu.pm | 2 +-
PVE/CLI/qm.pm | 2 +-
PVE/QemuServer.pm | 4 ++--
PVE/QemuServer/Monitor.pm | 4 ++--
PVE/VZDump/QemuServer.pm | 4 ++--
5 files changed, 8 insertions(+), 8 deletions(-)
pve-manager:
Fiona Ebner (2):
ui: qemu: hardware: use background delay for asynchronous remove tasks
ui: qemu: hardware: use asynchronous remove API call for disk
hot-unplug
www/manager6/qemu/HardwareView.js | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)
--
2.39.2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2024-05-03 11:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-03 11:19 Fiona Ebner [this message]
2024-05-03 11:19 ` [pve-devel] [PATCH qemu-server 1/5] monitor: allow passing timeout for a HMP command Fiona Ebner
2024-05-03 11:19 ` [pve-devel] [PATCH qemu-server 2/5] api: human monitor: increase timeout to 25 seconds Fiona Ebner
2024-05-03 11:19 ` [pve-devel] [PATCH qemu-server 3/5] vzdump: increase timeout for attaching drives to 60 seconds Fiona Ebner
2024-05-03 11:19 ` [pve-devel] [PATCH qemu-server 4/5] cli: qm: increase timeout for monitor commands to 30 seconds Fiona Ebner
2024-05-03 11:19 ` [pve-devel] [PATCH qemu-server 5/5] fix #5440: hmp helpers: drive{add, del}: increase timeout Fiona Ebner
2024-05-03 11:19 ` [pve-devel] [PATCH manager 1/2] ui: qemu: hardware: use background delay for asynchronous remove tasks Fiona Ebner
2024-05-03 11:19 ` [pve-devel] [PATCH manager 2/2] ui: qemu: hardware: use asynchronous remove API call for disk hot-unplug Fiona Ebner
2024-06-11 12:08 ` [pve-devel] applied-series: [PATCH-SERIES qemu-server/manager] fix #5440: HMP/disk timeout improvements Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240503111956.46543-1-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.