* [pve-devel] [PATCH v2 container 1/2] setup: support Ubuntu 24.04 Noble
@ 2024-04-30 14:42 Fiona Ebner
2024-04-30 14:42 ` [pve-devel] [PATCH v2 container 2/2] setup: unlink default netplan configuration even with Ubuntu >= 23.04 Fiona Ebner
2024-05-02 12:37 ` [pve-devel] applied-series: [PATCH v2 container 1/2] setup: support Ubuntu 24.04 Noble Thomas Lamprecht
0 siblings, 2 replies; 3+ messages in thread
From: Fiona Ebner @ 2024-04-30 14:42 UTC (permalink / raw)
To: pve-devel
Minimally tested, that an upgrade from an existing 23.04 container
works, there still is network and no obviously bad messages in the
container's journal.
Reported in the community forum:
https://forum.proxmox.com/threads/145848/
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
No changes in v2.
src/PVE/LXC/Setup/Ubuntu.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/PVE/LXC/Setup/Ubuntu.pm b/src/PVE/LXC/Setup/Ubuntu.pm
index 905cacb..cea8ef5 100644
--- a/src/PVE/LXC/Setup/Ubuntu.pm
+++ b/src/PVE/LXC/Setup/Ubuntu.pm
@@ -12,6 +12,7 @@ use PVE::LXC::Setup::Debian;
use base qw(PVE::LXC::Setup::Debian);
my $known_versions = {
+ '24.04' => 1, # noble
'23.10' => 1, # mantic
'23.04' => 1, # lunar
'22.10' => 1, # kinetic
--
2.39.2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* [pve-devel] [PATCH v2 container 2/2] setup: unlink default netplan configuration even with Ubuntu >= 23.04
2024-04-30 14:42 [pve-devel] [PATCH v2 container 1/2] setup: support Ubuntu 24.04 Noble Fiona Ebner
@ 2024-04-30 14:42 ` Fiona Ebner
2024-05-02 12:37 ` [pve-devel] applied-series: [PATCH v2 container 1/2] setup: support Ubuntu 24.04 Noble Thomas Lamprecht
1 sibling, 0 replies; 3+ messages in thread
From: Fiona Ebner @ 2024-04-30 14:42 UTC (permalink / raw)
To: pve-devel
It seems like commit 02d9462 ("setup: enable systemd-networkd via
preset for ubuntu 23.04+") also resulted in the default netplan
configuration no longer being unlinked. That should still happen, even
if systemd-networkd is now enabled via preset. Otherwise, the network
configuration created by Proxmox VE is not ordered before the one
generated by netplan and thus not applied by systemd-networkd.
Reported in the community forum:
https://forum.proxmox.com/threads/145848/post-658058
Fixes: 02d9462 ("setup: enable systemd-networkd via preset for ubuntu 23.04+")
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
New in v2.
src/PVE/LXC/Setup/Ubuntu.pm | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/PVE/LXC/Setup/Ubuntu.pm b/src/PVE/LXC/Setup/Ubuntu.pm
index cea8ef5..897eab9 100644
--- a/src/PVE/LXC/Setup/Ubuntu.pm
+++ b/src/PVE/LXC/Setup/Ubuntu.pm
@@ -73,7 +73,9 @@ sub template_fixup {
'/etc/systemd/system/multi-user.target.wants/systemd-networkd.service');
$self->ct_symlink('/lib/systemd/system/systemd-networkd.socket',
'/etc/systemd/system/socket.target.wants/systemd-networkd.socket');
+ }
+ if ($version >= '17.10') {
# unlink default netplan lxc config
$self->ct_unlink('/etc/netplan/10-lxc.yaml');
}
--
2.39.2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* [pve-devel] applied-series: [PATCH v2 container 1/2] setup: support Ubuntu 24.04 Noble
2024-04-30 14:42 [pve-devel] [PATCH v2 container 1/2] setup: support Ubuntu 24.04 Noble Fiona Ebner
2024-04-30 14:42 ` [pve-devel] [PATCH v2 container 2/2] setup: unlink default netplan configuration even with Ubuntu >= 23.04 Fiona Ebner
@ 2024-05-02 12:37 ` Thomas Lamprecht
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Lamprecht @ 2024-05-02 12:37 UTC (permalink / raw)
To: Proxmox VE development discussion, Fiona Ebner
On 30/04/2024 16:42, Fiona Ebner wrote:
> Minimally tested, that an upgrade from an existing 23.04 container
> works, there still is network and no obviously bad messages in the
> container's journal.
>
> Reported in the community forum:
> https://forum.proxmox.com/threads/145848/
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>
> No changes in v2.
>
> src/PVE/LXC/Setup/Ubuntu.pm | 1 +
> 1 file changed, 1 insertion(+)
>
>
applied both patches, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-05-02 12:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-30 14:42 [pve-devel] [PATCH v2 container 1/2] setup: support Ubuntu 24.04 Noble Fiona Ebner
2024-04-30 14:42 ` [pve-devel] [PATCH v2 container 2/2] setup: unlink default netplan configuration even with Ubuntu >= 23.04 Fiona Ebner
2024-05-02 12:37 ` [pve-devel] applied-series: [PATCH v2 container 1/2] setup: support Ubuntu 24.04 Noble Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal