* [pve-devel] [PATCH installer] install module: getters: correctly use plural in error messages
@ 2024-04-25 8:40 Alexander Zeidler
2024-04-25 8:40 ` [pve-devel] [PATCH installer] assistant: fix spelling and precise text in help usage output Alexander Zeidler
2024-04-25 15:53 ` [pve-devel] applied-series: [PATCH installer] install module: getters: correctly use plural in error messages Thomas Lamprecht
0 siblings, 2 replies; 3+ messages in thread
From: Alexander Zeidler @ 2024-04-25 8:40 UTC (permalink / raw)
To: pve-devel
Signed-off-by: Alexander Zeidler <a.zeidler@proxmox.com>
---
Proxmox/Install.pm | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm
index 6ad9d17..c0f8955 100644
--- a/Proxmox/Install.pm
+++ b/Proxmox/Install.pm
@@ -255,7 +255,7 @@ sub get_zfs_raid_setup {
$cmd .= " @$hd[1]";
}
} elsif ($filesys eq 'zfs (RAID1)') {
- die "zfs (RAID1) needs at least 2 device\n" if $diskcount < 2;
+ die "zfs (RAID1) needs at least 2 devices\n" if $diskcount < 2;
$cmd .= ' mirror ';
my $hd = @$devlist[0];
my $expected_size = @$hd[2]; # all disks need approximately same size
@@ -265,7 +265,7 @@ sub get_zfs_raid_setup {
$cmd .= " @$hd[1]";
}
} elsif ($filesys eq 'zfs (RAID10)') {
- die "zfs (RAID10) needs at least 4 device\n" if $diskcount < 4;
+ die "zfs (RAID10) needs at least 4 devices\n" if $diskcount < 4;
die "zfs (RAID10) needs an even number of devices\n" if $diskcount & 1;
for (my $i = 0; $i < $diskcount; $i+=2) {
@@ -329,10 +329,10 @@ sub get_btrfs_raid_setup {
if ($filesys eq 'btrfs (RAID0)') {
$mode = 'raid0';
} elsif ($filesys eq 'btrfs (RAID1)') {
- die "btrfs (RAID1) needs at least 2 device\n" if $diskcount < 2;
+ die "btrfs (RAID1) needs at least 2 devices\n" if $diskcount < 2;
$mode = 'raid1';
} elsif ($filesys eq 'btrfs (RAID10)') {
- die "btrfs (RAID10) needs at least 4 device\n" if $diskcount < 4;
+ die "btrfs (RAID10) needs at least 4 devices\n" if $diskcount < 4;
$mode = 'raid10';
} else {
die "unknown btrfs mode '$filesys'\n";
--
2.39.2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* [pve-devel] [PATCH installer] assistant: fix spelling and precise text in help usage output
2024-04-25 8:40 [pve-devel] [PATCH installer] install module: getters: correctly use plural in error messages Alexander Zeidler
@ 2024-04-25 8:40 ` Alexander Zeidler
2024-04-25 15:53 ` [pve-devel] applied-series: [PATCH installer] install module: getters: correctly use plural in error messages Thomas Lamprecht
1 sibling, 0 replies; 3+ messages in thread
From: Alexander Zeidler @ 2024-04-25 8:40 UTC (permalink / raw)
To: pve-devel
Signed-off-by: Alexander Zeidler <a.zeidler@proxmox.com>
---
proxmox-auto-install-assistant/src/main.rs | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/proxmox-auto-install-assistant/src/main.rs b/proxmox-auto-install-assistant/src/main.rs
index 9bc083e..0debd29 100644
--- a/proxmox-auto-install-assistant/src/main.rs
+++ b/proxmox-auto-install-assistant/src/main.rs
@@ -91,16 +91,16 @@ struct CommandValidateAnswer {
/// Prepare an ISO for automated installation.
///
-/// The behavior of how to fetch an answer file must be set with the '--fetch-from', parameter. The
+/// The behavior of how to fetch an answer file must be set with the '--fetch-from' parameter. The
/// answer file can be:{n}
/// * integrated into the ISO itself ('iso'){n}
-/// * needs to be present in a partition / file-system with the label 'PROXMOX-AIS' (Proxmox
+/// * present on a partition / file-system with the label 'PROXMOX-AIS' (Proxmox
/// Automated Installer Source) ('partition'){n}
-/// * get requested via an HTTP Post request ('http').
+/// * requested via an HTTP Post request ('http').
///
/// The URL for the HTTP mode can be defined for the ISO with the '--url' argument. If not present,
-/// it will try to get a URL from a DHCP option (250, TXT) or by querying a DNS TXT record at
-/// 'proxmox-auto-installer.{search domain}'.
+/// it will try to get a URL from a DHCP option (250, TXT) or by querying a DNS TXT record for the
+/// domain 'proxmox-auto-installer.{search domain}'.
///
/// The TLS certificate fingerprint can either be defined via the '--cert-fingerprint' argument or
/// alternatively via the custom DHCP option (251, TXT) or in a DNS TXT record located at
--
2.39.2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* [pve-devel] applied-series: [PATCH installer] install module: getters: correctly use plural in error messages
2024-04-25 8:40 [pve-devel] [PATCH installer] install module: getters: correctly use plural in error messages Alexander Zeidler
2024-04-25 8:40 ` [pve-devel] [PATCH installer] assistant: fix spelling and precise text in help usage output Alexander Zeidler
@ 2024-04-25 15:53 ` Thomas Lamprecht
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Lamprecht @ 2024-04-25 15:53 UTC (permalink / raw)
To: Proxmox VE development discussion, Alexander Zeidler
Am 25/04/2024 um 10:40 schrieb Alexander Zeidler:
> Signed-off-by: Alexander Zeidler <a.zeidler@proxmox.com>
> ---
> Proxmox/Install.pm | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>
applied both patches, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-25 15:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-25 8:40 [pve-devel] [PATCH installer] install module: getters: correctly use plural in error messages Alexander Zeidler
2024-04-25 8:40 ` [pve-devel] [PATCH installer] assistant: fix spelling and precise text in help usage output Alexander Zeidler
2024-04-25 15:53 ` [pve-devel] applied-series: [PATCH installer] install module: getters: correctly use plural in error messages Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal