* [pbs-devel] [PATCH proxmox-backup] ui: fix layout reset
@ 2024-04-22 11:06 Dominik Csapak
2024-04-22 11:57 ` [pbs-devel] applied: " Fabian Grünbichler
0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2024-04-22 11:06 UTC (permalink / raw)
To: pbs-devel
we have to iterate over the keys of the state object here, not over the
values. This meant one could not reset the layout from the settings
window.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/window/Settings.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/window/Settings.js b/www/window/Settings.js
index 763cefab..c785dd88 100644
--- a/www/window/Settings.js
+++ b/www/window/Settings.js
@@ -96,7 +96,7 @@ Ext.define('PBS.window.Settings', {
click: function() {
let blacklist = ['login-username'];
let sp = Ext.state.Manager.getProvider();
- for (const state of Object.values(sp.state)) {
+ for (const state of Object.keys(sp.state)) {
if (blacklist.indexOf(state) !== -1) {
continue;
}
--
2.39.2
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pbs-devel] applied: [PATCH proxmox-backup] ui: fix layout reset
2024-04-22 11:06 [pbs-devel] [PATCH proxmox-backup] ui: fix layout reset Dominik Csapak
@ 2024-04-22 11:57 ` Fabian Grünbichler
0 siblings, 0 replies; 2+ messages in thread
From: Fabian Grünbichler @ 2024-04-22 11:57 UTC (permalink / raw)
To: Proxmox Backup Server development discussion
thanks!
On April 22, 2024 1:06 pm, Dominik Csapak wrote:
> we have to iterate over the keys of the state object here, not over the
> values. This meant one could not reset the layout from the settings
> window.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> www/window/Settings.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/www/window/Settings.js b/www/window/Settings.js
> index 763cefab..c785dd88 100644
> --- a/www/window/Settings.js
> +++ b/www/window/Settings.js
> @@ -96,7 +96,7 @@ Ext.define('PBS.window.Settings', {
> click: function() {
> let blacklist = ['login-username'];
> let sp = Ext.state.Manager.getProvider();
> - for (const state of Object.values(sp.state)) {
> + for (const state of Object.keys(sp.state)) {
> if (blacklist.indexOf(state) !== -1) {
> continue;
> }
> --
> 2.39.2
>
>
>
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
>
>
>
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-04-22 11:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-22 11:06 [pbs-devel] [PATCH proxmox-backup] ui: fix layout reset Dominik Csapak
2024-04-22 11:57 ` [pbs-devel] applied: " Fabian Grünbichler
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal