From: Friedrich Weber <f.weber@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH qemu-server 2/4] api: stop: reword overrule-shutdown parameter description
Date: Thu, 18 Apr 2024 15:46:35 +0200 [thread overview]
Message-ID: <20240418134637.262082-3-f.weber@proxmox.com> (raw)
In-Reply-To: <20240418134637.262082-1-f.weber@proxmox.com>
The previous wording made it sound like all "visible" tasks were
aborted, which is not the case: A user with Sys.Audit but without
Sys.Modify may see a task that was started by a different user, but
overrule-shutdown would not abort the task.
Change wording to better reflect that not all visible tasks may be
aborted.
Also, add a full-stop that was previously missing.
Signed-off-by: Friedrich Weber <f.weber@proxmox.com>
---
PVE/API2/Qemu.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index 00cd907..2a349c8 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2/Qemu.pm
@@ -3043,7 +3043,7 @@ __PACKAGE__->register_method({
default => 0,
},
'overrule-shutdown' => {
- description => "Abort any active and visible 'qmshutdown' tasks before stopping",
+ description => "Try to abort active 'qmshutdown' tasks before stopping.",
optional => 1,
type => 'boolean',
default => 0,
--
2.39.2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-04-18 13:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 13:46 [pve-devel] [PATCH qemu-server/container/docs 0/4] overrule-shutdown: documentation fixes Friedrich Weber
2024-04-18 13:46 ` [pve-devel] [PATCH qemu-server 1/4] api: fix spacing and punctuation in shutdown and stop descriptions Friedrich Weber
2024-04-18 13:46 ` Friedrich Weber [this message]
2024-04-18 13:46 ` [pve-devel] [PATCH container 3/4] api: stop: reword overrule-shutdown parameter description Friedrich Weber
2024-04-18 13:46 ` [pve-devel] [PATCH docs 4/4] qm: add overrule-shutdown to CLI usage examples Friedrich Weber
2024-04-18 21:10 ` [pve-devel] applied-series: [PATCH qemu-server/container/docs 0/4] overrule-shutdown: documentation fixes Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240418134637.262082-3-f.weber@proxmox.com \
--to=f.weber@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.