all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v4 manager 5/5] ui: backup job: move repeat-missed option to advanced tab
Date: Tue, 16 Apr 2024 14:09:55 +0200	[thread overview]
Message-ID: <20240416120957.75269-6-f.ebner@proxmox.com> (raw)
In-Reply-To: <20240416120957.75269-1-f.ebner@proxmox.com>

Suggested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---

New in v4.

 www/manager6/dc/Backup.js                   | 12 ------------
 www/manager6/panel/BackupAdvancedOptions.js | 14 ++++++++++++++
 2 files changed, 14 insertions(+), 12 deletions(-)

diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js
index 221fe17c..3ff2bff4 100644
--- a/www/manager6/dc/Backup.js
+++ b/www/manager6/dc/Backup.js
@@ -418,18 +418,6 @@ Ext.define('PVE.dc.BackupEdit', {
 				    },
 				},
 			    ],
-			    advancedColumn1: [
-				{
-				    xtype: 'proxmoxcheckbox',
-				    fieldLabel: gettext('Repeat missed'),
-				    name: 'repeat-missed',
-				    uncheckedValue: 0,
-				    defaultValue: 0,
-				    cbind: {
-					deleteDefaultValue: '{!isCreate}',
-				    },
-				},
-			    ],
 			    onGetValues: function(values) {
 				return this.up('window').getController().onGetValues(values);
 			    },
diff --git a/www/manager6/panel/BackupAdvancedOptions.js b/www/manager6/panel/BackupAdvancedOptions.js
index 11a39352..066b2c47 100644
--- a/www/manager6/panel/BackupAdvancedOptions.js
+++ b/www/manager6/panel/BackupAdvancedOptions.js
@@ -122,6 +122,16 @@ Ext.define('PVE.panel.BackupAdvancedOptions', {
 		deleteEmpty: '{!isCreate}',
 	    },
 	},
+	{
+	    xtype: 'proxmoxcheckbox',
+	    fieldLabel: gettext('Repeat missed'),
+	    name: 'repeat-missed',
+	    uncheckedValue: 0,
+	    defaultValue: 0,
+	    cbind: {
+		deleteDefaultValue: '{!isCreate}',
+	    },
+	},
     ],
 
     column2: [
@@ -142,6 +152,10 @@ Ext.define('PVE.panel.BackupAdvancedOptions', {
 	    value: 'TODO',
 	    hidden: true, // see definition of pbs-entries-max field
 	},
+	{
+	    xtype: 'displayfield',
+	    value: gettext('Run missed jobs as soon as possible'),
+	},
     ],
 
     columnB: [
-- 
2.39.2





  parent reply	other threads:[~2024-04-16 12:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-16 12:09 [pve-devel] [PATCH-SERIES v4 manager/docs] close #4513: add advanced tab for backup jobs and improve performance fallback/default Fiona Ebner
2024-04-16 12:09 ` [pve-devel] [PATCH v4 manager 1/5] vzdump: actually honor schema defaults for performance Fiona Ebner
2024-04-16 12:09 ` [pve-devel] [PATCH v4 manager 2/5] vzdump: use per-property fallback for performance settings Fiona Ebner
2024-04-16 12:09 ` [pve-devel] [PATCH v4 manager 3/5] close #4513: ui: backup job: add tab for advanced options Fiona Ebner
2024-04-16 12:09 ` [pve-devel] [PATCH v4 manager 4/5] ui: backup job: disable zstd thread count field when zstd isn't used Fiona Ebner
2024-04-16 12:09 ` Fiona Ebner [this message]
2024-04-16 12:09 ` [pve-devel] [PATCH v4 docs 1/2] backup: update information about performance settings Fiona Ebner
2024-04-16 12:09 ` [pve-devel] [PATCH v4 docs 2/2] backup: clarify where repeat-missed option can be found now Fiona Ebner
2024-04-17 14:06 ` [pve-devel] applied-series: [PATCH-SERIES v4 manager/docs] close #4513: add advanced tab for backup jobs and improve performance fallback/default Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240416120957.75269-6-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal