From: Filip Schauer <f.schauer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH common/container v2 0/2] fix invalid device passthrough being added to config
Date: Mon, 15 Apr 2024 15:17:00 +0200 [thread overview]
Message-ID: <20240415131702.94922-1-f.schauer@proxmox.com> (raw)
Fix a bug that allows a device passthrough entry to be added to the
config despite the device path not pointing to a device. Previously,
adding an invalid device passthrough entry would throw an error, but the
entry would still be added to the config. This is fixed by moving the
respective checks from update_lxc_config to update_pct_config, which is
run before the entry is written to the config file.
Changes since v1:
* Use "if" instead of "unless"
* Move device path validation and stat to seperate helper function
pve-common:
Filip Schauer (1):
add get_device_stat helper subroutine
src/PVE/Tools.pm | 18 +++++++++++++++++-
1 file changed, 17 insertions(+), 1 deletion(-)
pve-container:
Filip Schauer (1):
fix invalid device passthrough being added to config
src/PVE/LXC.pm | 18 ++++--------------
src/PVE/LXC/Config.pm | 11 ++++++++++-
2 files changed, 14 insertions(+), 15 deletions(-)
Summary over all repositories:
3 files changed, 31 insertions(+), 16 deletions(-)
--
Generated by git-murpp 0.6.0
next reply other threads:[~2024-04-15 13:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 13:17 Filip Schauer [this message]
2024-04-15 13:17 ` [pve-devel] [PATCH common v2 1/2] add get_device_stat helper subroutine Filip Schauer
2024-04-15 13:54 ` Fiona Ebner
2024-04-16 9:28 ` Filip Schauer
2024-04-15 13:17 ` [pve-devel] [PATCH container v2 2/2] fix invalid device passthrough being added to config Filip Schauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240415131702.94922-1-f.schauer@proxmox.com \
--to=f.schauer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.