From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve-flutter-frontend 7/9] task logs: don't always say 'Last Task: '
Date: Fri, 12 Apr 2024 10:04:56 +0200 [thread overview]
Message-ID: <20240412080458.1066580-8-d.csapak@proxmox.com> (raw)
In-Reply-To: <20240412080458.1066580-1-d.csapak@proxmox.com>
only put that when we show the last task, which is only when we show the
'more tasks' button. Make the title otherwise just 'Task: '
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
lib/widgets/pve_task_log_expansiontile_widget.dart | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/widgets/pve_task_log_expansiontile_widget.dart b/lib/widgets/pve_task_log_expansiontile_widget.dart
index a3c36fd..2073840 100644
--- a/lib/widgets/pve_task_log_expansiontile_widget.dart
+++ b/lib/widgets/pve_task_log_expansiontile_widget.dart
@@ -52,6 +52,8 @@ class _PveTaskExpansionTileState extends State<PveTaskExpansionTile> {
? (widget.headerColorExpanded ?? colorScheme.onSurface)
: (widget.headerColor ?? colorScheme.onBackground);
+ final taskText = widget.showMorePage != null ? 'Last Task' : 'Task';
+
return ExpansionTile(
onExpansionChanged: (value) {
setState(() {
@@ -66,7 +68,7 @@ class _PveTaskExpansionTileState extends State<PveTaskExpansionTile> {
color: hasError ? errorColor : headerColor,
),
title: Text(
- 'Last Task: ${widget.task.type}',
+ '$taskText: ${widget.task.type}',
style: TextStyle(color: headerColor),
),
subtitle: isFinished
--
2.39.2
next prev parent reply other threads:[~2024-04-12 8:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 8:04 [pve-devel] [PATCH pve-flutter-frontend 0/9] small improvements Dominik Csapak
2024-04-12 8:04 ` [pve-devel] [PATCH pve-flutter-frontend 1/9] replace BottomNavigationBar with NavigationBar Dominik Csapak
2024-04-12 8:04 ` [pve-devel] [PATCH pve-flutter-frontend 2/9] resource tab: improve colors for headers Dominik Csapak
2024-04-12 8:04 ` [pve-devel] [PATCH pve-flutter-frontend 3/9] node overview: don't throw permission errors on every update Dominik Csapak
2024-04-12 8:04 ` [pve-devel] [PATCH pve-flutter-frontend 4/9] adapt to material 3 changes for themes Dominik Csapak
2024-04-12 8:04 ` [pve-devel] [PATCH pve-flutter-frontend 5/9] fix clipping for data card widget Dominik Csapak
2024-04-12 8:04 ` [pve-devel] [PATCH pve-flutter-frontend 6/9] set the color of the template indicator to that of the icon Dominik Csapak
2024-04-12 8:04 ` Dominik Csapak [this message]
2024-04-12 8:04 ` [pve-devel] [PATCH pve-flutter-frontend 8/9] task logs: use separate color for warnings Dominik Csapak
2024-04-12 8:04 ` [pve-devel] [PATCH pve-flutter-frontend 9/9] task log list: make warning icon more distinct Dominik Csapak
2024-04-16 14:15 ` [pve-devel] applied: [PATCH pve-flutter-frontend 0/9] small improvements Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240412080458.1066580-8-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal