all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH-SERIES v2 qemu-server] improve error detection/messages for some block jobs
Date: Thu, 11 Apr 2024 13:16:02 +0200	[thread overview]
Message-ID: <20240411111606.73267-1-f.ebner@proxmox.com> (raw)

Changes in v2:
    * Also do not auto-dismiss for the stream job for the new
      live-import feature.

When auto-dismiss=true (the default), a failed job can disappear very
quickly from the job list and there might not be any chance to see the
error in the result of 'query-block-jobs'. For jobs with $completion
being 'auto', like 'block-stream', it couldn't even be detected that
the job failed.

Jobs with auto-dismiss=false on the other hand, will wait in
'concluded' state until manually dismissed. For those, it will be
possible to query the error if the job failed.

This series makes 'drive-mirror' and 'block-stream' jobs do just that.

There doesn't seem to be a way to have only failed jobs stay around,
e.g. something like auto-dismiss=on-success.


Fiona Ebner (4):
  blockjob: anticipate jobs with auto-dismiss=false for better error
    messages and detection
  mirror: do not auto-dismiss to allow getting error message from job
  live restore: do not auto-dismiss stream job to improve error message
    and detection
  live import: do not auto-dismiss stream job to improve error message
    and detection

 PVE/QemuServer.pm | 35 +++++++++++++++++++++++++++++++++--
 1 file changed, 33 insertions(+), 2 deletions(-)

-- 
2.39.2





             reply	other threads:[~2024-04-11 11:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-11 11:16 Fiona Ebner [this message]
2024-04-11 11:16 ` [pve-devel] [PATCH v2 qemu-server 1/4] blockjob: anticipate jobs with auto-dismiss=false for better error messages and detection Fiona Ebner
2024-04-11 11:16 ` [pve-devel] [PATCH v2 qemu-server 2/4] mirror: do not auto-dismiss to allow getting error message from job Fiona Ebner
2024-04-11 11:16 ` [pve-devel] [PATCH v2 qemu-server 3/4] live restore: do not auto-dismiss stream job to improve error message and detection Fiona Ebner
2024-04-11 11:16 ` [pve-devel] [PATCH v2 qemu-server 4/4] live import: " Fiona Ebner
2024-07-02 14:08 ` [pve-devel] applied-series: [PATCH-SERIES v2 qemu-server] improve error detection/messages for some block jobs Fabian Grünbichler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240411111606.73267-1-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal