all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH] d/postinst: don't treat reload/restart failure as fatal
Date: Thu, 11 Apr 2024 11:45:36 +0200	[thread overview]
Message-ID: <20240411094536.150914-1-f.gruenbichler@proxmox.com> (raw)

aborting apt invocations because of service failures like that is always
painful, and lxcfs is in a lot of our build-dep chains, and build environments
might not run systemd as init.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---
 debian/lxcfs.postinst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/lxcfs.postinst b/debian/lxcfs.postinst
index 558a0d0..ae1b7a2 100644
--- a/debian/lxcfs.postinst
+++ b/debian/lxcfs.postinst
@@ -15,7 +15,7 @@ case "$1" in
     unit=lxcfs.service
     if systemctl -q is-enabled "$unit"; then
         systemctl --system daemon-reload >/dev/null || true
-        deb-systemd-invoke $dh_action "$unit"
+        deb-systemd-invoke $dh_action "$unit" || true
     fi
   ;;
 
-- 
2.39.2





             reply	other threads:[~2024-04-11  9:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-11  9:45 Fabian Grünbichler [this message]
2024-04-11  9:50 ` [pve-devel] applied: " Wolfgang Bumiller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240411094536.150914-1-f.gruenbichler@proxmox.com \
    --to=f.gruenbichler@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal