From: Stefan Lendl <s.lendl@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH v4 proxmox-backup 7/8] ui: show removed and pending data of last run in bytes
Date: Thu, 4 Apr 2024 15:50:35 +0200 [thread overview]
Message-ID: <20240404135028.373407-16-s.lendl@proxmox.com> (raw)
In-Reply-To: <20240404135028.373407-2-s.lendl@proxmox.com>
Show the removed and pending data of the last run formatted with
Proxmox.Utils.format_size for better readability identically to data
display in the overview tab.
Signed-off-by: Stefan Lendl <s.lendl@proxmox.com>
Tested-by: Gabriel Goller <g.goller@proxmox.com>
Reviewd-by: Gabriel Goller <g.goller@proxmox.com>
Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
Suggested-by: Lukas Wagner <l.wagner@proxmox.com>
---
www/config/GCView.js | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/www/config/GCView.js b/www/config/GCView.js
index 63e84111..6e1a6d06 100644
--- a/www/config/GCView.js
+++ b/www/config/GCView.js
@@ -1,7 +1,7 @@
Ext.define('pbs-gc-jobs-status', {
extend: 'Ext.data.Model',
fields: [
- 'store', 'last-run-upid', 'removed-chunks', 'pending-chunks', 'schedule',
+ 'store', 'last-run-upid', 'removed-bytes', 'pending-bytes', 'schedule',
'next-run', 'last-run-endtime', 'last-run-state',
{
name: 'duration',
@@ -203,6 +203,20 @@ Ext.define('PBS.config.GCJobView', {
width: 150,
sortable: true,
},
+ {
+ header: gettext('Removed Data'),
+ dataIndex: 'removed-bytes',
+ renderer: (value) => value !== undefined ?
+ Proxmox.Utils.format_size(value, true) : "-",
+ sortable: false,
+ },
+ {
+ header: gettext('Pending Data'),
+ dataIndex: 'pending-bytes',
+ renderer: (value) => value !== undefined ?
+ Proxmox.Utils.format_size(value, true) : "-",
+ sortable: false,
+ },
],
initComponent: function() {
--
2.44.0
next prev parent reply other threads:[~2024-04-04 13:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-04 13:50 [pbs-devel] [PATCH v4 proxmox-backup 0/8] Add GC job status to datastore and global prune job view Stefan Lendl
2024-04-04 13:50 ` [pbs-devel] [PATCH v4 proxmox-backup 1/8] api: garbage collect job status Stefan Lendl
2024-04-04 13:50 ` [pbs-devel] [PATCH v4 proxmox-backup 2/8] ui: global prune and gc job view Stefan Lendl
2024-04-04 13:50 ` [pbs-devel] [PATCH v4 proxmox-backup 3/8] ui: move prune and gc widget to config Stefan Lendl
2024-04-04 13:50 ` [pbs-devel] [PATCH v4 proxmox-backup 4/8] ui: hide datastore column in local gc view Stefan Lendl
2024-04-04 13:50 ` [pbs-devel] [PATCH v4 proxmox-backup 5/8] ui: order Prune & GC before Sync Jobs Stefan Lendl
2024-04-04 13:50 ` [pbs-devel] [PATCH v4 proxmox-backup 6/8] cli: list gc jobs with proxmox-backup-manager Stefan Lendl
2024-04-04 13:50 ` Stefan Lendl [this message]
2024-04-04 13:50 ` [pbs-devel] [PATCH v4 proxmox-backup 8/8] ui: configure width and flex on GC Jobs columns Stefan Lendl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240404135028.373407-16-s.lendl@proxmox.com \
--to=s.lendl@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.