From: Gabriel Goller <g.goller@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup v2 2/2] fix #5188: gui: add copy to clipboard on snapshots
Date: Thu, 14 Mar 2024 10:32:24 +0100 [thread overview]
Message-ID: <20240314093227.44927-2-g.goller@proxmox.com> (raw)
In-Reply-To: <20240314093227.44927-1-g.goller@proxmox.com>
When navigating to Datastores -> Content, it is now possible to
right-click on a snapshot/group and copy the name to the clipboard.
This makes the proxmox-backup-client much easier to use, especially when
restoring archives.
Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
---
v2, thanks @Dominik:
- change name to 'copy name to clipboard' to avoid confusion
www/datastore/Content.js | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/www/datastore/Content.js b/www/datastore/Content.js
index fa0b7d2c..c2403ff9 100644
--- a/www/datastore/Content.js
+++ b/www/datastore/Content.js
@@ -546,6 +546,10 @@ Ext.define('PBS.DataStoreContent', {
});
},
+ onCopy: async function(view, rI, cI, item, e, { data }) {
+ await navigator.clipboard.writeText(data.text);
+ },
+
onNotesEdit: function(view, data) {
let me = this;
@@ -884,6 +888,7 @@ Ext.define('PBS.DataStoreContent', {
if (record.data.ty === 'group') {
menu = Ext.create('PBS.datastore.GroupCmdMenu', {
title: gettext('Group'),
+ onCopy: createControllerCallback('onCopy'),
onVerify: createControllerCallback('onVerify'),
onChangeOwner: createControllerCallback('onChangeOwner'),
onPrune: createControllerCallback('onPrune'),
@@ -892,6 +897,7 @@ Ext.define('PBS.DataStoreContent', {
} else if (record.data.ty === 'dir') {
menu = Ext.create('PBS.datastore.SnapshotCmdMenu', {
title: gettext('Snapshot'),
+ onCopy: createControllerCallback('onCopy'),
onVerify: createControllerCallback('onVerify'),
onProtectionChange: createControllerCallback('onProtectionChange'),
onForget: createControllerCallback('onForget'),
@@ -1284,12 +1290,21 @@ Ext.define('PBS.datastore.GroupCmdMenu', {
extend: 'Ext.menu.Menu',
mixins: ['Proxmox.Mixin.CBind'],
+ onCopy: undefined,
onVerify: undefined,
onChangeOwner: undefined,
onPrune: undefined,
onForget: undefined,
items: [
+ {
+ text: gettext('Copy name to clipboard'),
+ iconCls: 'fa fa-clipboard',
+ handler: function() { this.up('menu').onCopy(); },
+ cbind: {
+ hidden: '{!onCopy}',
+ },
+ },
{
text: gettext('Verify'),
iconCls: 'pve-icon-verify-lettering',
@@ -1330,11 +1345,21 @@ Ext.define('PBS.datastore.SnapshotCmdMenu', {
extend: 'Ext.menu.Menu',
mixins: ['Proxmox.Mixin.CBind'],
+ onCopy: undefined,
onVerify: undefined,
onProtectionChange: undefined,
onForget: undefined,
items: [
+ {
+ text: gettext('Copy name to clipboard'),
+ iconCls: 'fa fa-clipboard',
+ handler: function() { this.up('menu').onCopy(); },
+ cbind: {
+ hidden: '{!onCopy}',
+ disabled: '{!onCopy}',
+ },
+ },
{
text: gettext('Verify'),
iconCls: 'pve-icon-verify-lettering',
--
2.43.0
next prev parent reply other threads:[~2024-03-14 9:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-14 9:32 [pbs-devel] [PATCH proxmox-backup v2 1/2] gui: remove document.execCommand calls Gabriel Goller
2024-03-14 9:32 ` Gabriel Goller [this message]
2024-03-25 15:46 ` [pbs-devel] applied-series: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240314093227.44927-2-g.goller@proxmox.com \
--to=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.