* [pve-devel] [PATCH qemu-server] disk import: warn when fallback is used instead of requested format
@ 2024-03-11 9:46 Fiona Ebner
2024-03-14 14:52 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Fiona Ebner @ 2024-03-11 9:46 UTC (permalink / raw)
To: pve-devel
Might avoid some confusion. Reported in the community forum:
https://forum.proxmox.com/threads/142988/
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
PVE/QemuServer/ImportDisk.pm | 2 ++
1 file changed, 2 insertions(+)
diff --git a/PVE/QemuServer/ImportDisk.pm b/PVE/QemuServer/ImportDisk.pm
index 3e0474b6..132932ae 100755
--- a/PVE/QemuServer/ImportDisk.pm
+++ b/PVE/QemuServer/ImportDisk.pm
@@ -28,6 +28,8 @@ sub do_import {
# get target format, target image's path, and whether it's possible to sparseinit
my $storecfg = PVE::Storage::config();
my $dst_format = PVE::QemuServer::resolve_dst_disk_format($storecfg, $storage_id, undef, $format);
+ warn "format '$format' is not supported by the target storage - using '$dst_format' instead\n"
+ if $format && $format ne $dst_format;
my $dst_volid = PVE::Storage::vdisk_alloc($storecfg, $storage_id, $vmid, $dst_format, undef, $src_size / 1024);
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH qemu-server] disk import: warn when fallback is used instead of requested format
2024-03-11 9:46 [pve-devel] [PATCH qemu-server] disk import: warn when fallback is used instead of requested format Fiona Ebner
@ 2024-03-14 14:52 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2024-03-14 14:52 UTC (permalink / raw)
To: Proxmox VE development discussion, Fiona Ebner
Am 11/03/2024 um 10:46 schrieb Fiona Ebner:
> Might avoid some confusion. Reported in the community forum:
> https://forum.proxmox.com/threads/142988/
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> PVE/QemuServer/ImportDisk.pm | 2 ++
> 1 file changed, 2 insertions(+)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-14 14:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-11 9:46 [pve-devel] [PATCH qemu-server] disk import: warn when fallback is used instead of requested format Fiona Ebner
2024-03-14 14:52 ` [pve-devel] applied: " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal