* [pmg-devel] [PATCH pmg-gui] ui: trim whitespaces when adding a subscription key
@ 2024-03-01 9:54 Stefan Sterz
2024-03-01 10:41 ` [pmg-devel] applied: " Stoiko Ivanov
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Sterz @ 2024-03-01 9:54 UTC (permalink / raw)
To: pmg-devel
users that add the correct subscription key just get unnecessarily
confused with a "value does not match the regex pattern" error if
they accidentally have a stray whitespace at the end or beginning
otherwise.
Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
---
js/Subscription.js | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/js/Subscription.js b/js/Subscription.js
index 2293cdb..6d7380c 100644
--- a/js/Subscription.js
+++ b/js/Subscription.js
@@ -8,7 +8,8 @@ Ext.define('PMG.SubscriptionKeyEdit', {
onlineHelp: 'getting_help',
items: {
- xtype: 'textfield',
+ xtype: 'proxmoxtextfield',
+ trimValue: true,
name: 'key',
value: '',
fieldLabel: gettext('Subscription Key'),
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pmg-devel] applied: [PATCH pmg-gui] ui: trim whitespaces when adding a subscription key
2024-03-01 9:54 [pmg-devel] [PATCH pmg-gui] ui: trim whitespaces when adding a subscription key Stefan Sterz
@ 2024-03-01 10:41 ` Stoiko Ivanov
0 siblings, 0 replies; 2+ messages in thread
From: Stoiko Ivanov @ 2024-03-01 10:41 UTC (permalink / raw)
To: Stefan Sterz; +Cc: pmg-devel
Thanks for the patch! applied after testing it in a fresh pmg-8.1 container
On Fri, 1 Mar 2024 10:54:30 +0100
Stefan Sterz <s.sterz@proxmox.com> wrote:
> users that add the correct subscription key just get unnecessarily
> confused with a "value does not match the regex pattern" error if
> they accidentally have a stray whitespace at the end or beginning
> otherwise.
>
> Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
> ---
> js/Subscription.js | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/js/Subscription.js b/js/Subscription.js
> index 2293cdb..6d7380c 100644
> --- a/js/Subscription.js
> +++ b/js/Subscription.js
> @@ -8,7 +8,8 @@ Ext.define('PMG.SubscriptionKeyEdit', {
> onlineHelp: 'getting_help',
>
> items: {
> - xtype: 'textfield',
> + xtype: 'proxmoxtextfield',
> + trimValue: true,
> name: 'key',
> value: '',
> fieldLabel: gettext('Subscription Key'),
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-01 10:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-01 9:54 [pmg-devel] [PATCH pmg-gui] ui: trim whitespaces when adding a subscription key Stefan Sterz
2024-03-01 10:41 ` [pmg-devel] applied: " Stoiko Ivanov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal