* [pve-devel] [PATCH manager] appliance index: fix precedence in size check for log rotation
@ 2024-02-28 12:07 Fiona Ebner
2024-02-28 13:43 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Fiona Ebner @ 2024-02-28 12:07 UTC (permalink / raw)
To: pve-devel
In Perl, > takes precedence over ||, see perldoc perlop, so currently
the check will trigger with any size.
Fixes: 805cae93 ("appliance index: rotate update log if bigger than 256 KiB")
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
PVE/APLInfo.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/APLInfo.pm b/PVE/APLInfo.pm
index a4acf490..07542743 100644
--- a/PVE/APLInfo.pm
+++ b/PVE/APLInfo.pm
@@ -213,7 +213,7 @@ sub get_apl_sources {
sub update {
my ($proxy) = @_;
- if (-s $logfile || 0 > 1024 * 256) {
+ if ((-s $logfile || 0) > 1024 * 256) {
rename($logfile, "$logfile.0");
}
my $logfd = IO::File->new (">>$logfile");
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH manager] appliance index: fix precedence in size check for log rotation
2024-02-28 12:07 [pve-devel] [PATCH manager] appliance index: fix precedence in size check for log rotation Fiona Ebner
@ 2024-02-28 13:43 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2024-02-28 13:43 UTC (permalink / raw)
To: Proxmox VE development discussion, Fiona Ebner
Am 28/02/2024 um 13:07 schrieb Fiona Ebner:
> In Perl, > takes precedence over ||, see perldoc perlop, so currently
> the check will trigger with any size.
>
> Fixes: 805cae93 ("appliance index: rotate update log if bigger than 256 KiB")
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> PVE/APLInfo.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-28 13:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-28 12:07 [pve-devel] [PATCH manager] appliance index: fix precedence in size check for log rotation Fiona Ebner
2024-02-28 13:43 ` [pve-devel] applied: " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal