all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pmg-devel@lists.proxmox.com
Subject: [pmg-devel] applied: [PATCH gui 4/4] dashboard: show ten of the current top receiver
Date: Mon, 26 Feb 2024 17:28:53 +0100	[thread overview]
Message-ID: <20240226162853.2519262-4-t.lamprecht@proxmox.com> (raw)
In-Reply-To: <20240226162853.2519262-1-t.lamprecht@proxmox.com>

not only five, as with the higher panels we already got enough space,
as one row needs roughly 24 px, lower top/bottom padding a bit to get
~242 of space, fitting ten entries nicely.

The performance aspect should not matter much, getting five or ten
entries from a DB like PostgreSQL is really not costing much,
especially as with the count query in use the hard work has already
been done anyway.

Makes the top-receiver panel look a bit more coherent compared to the
node info one beside it.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
---
 js/Dashboard.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/js/Dashboard.js b/js/Dashboard.js
index d03510e..9c51734 100644
--- a/js/Dashboard.js
+++ b/js/Dashboard.js
@@ -283,6 +283,7 @@ Ext.define('PMG.Dashboard', {
 		    url: '/api2/json/statistics/recentreceivers',
 		    extraParams: {
 			hours: '{hours}',
+			limit: 10, // make this also configurable?
 		    },
 		},
 		fields: [
@@ -427,7 +428,7 @@ Ext.define('PMG.Dashboard', {
 	    iconCls: 'fa fa-list',
 	    title: gettext('Top Receivers'),
 
-	    bodyPadding: '20 20 20 20',
+	    bodyPadding: '10 10 10 10',
 	    layout: {
 		type: 'vbox',
 		pack: 'center',
-- 
2.39.2





      parent reply	other threads:[~2024-02-26 18:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-26 16:28 [pmg-devel] applied: [PATCH gui 1/4] dashboard: reduce noise in current kernel version Thomas Lamprecht
2024-02-26 16:28 ` [pmg-devel] applied: [PATCH gui 2/4] dashboard: show boot-mode information Thomas Lamprecht
2024-02-26 16:28 ` [pmg-devel] applied [PATCH gui 3/4] dashboard: increase height of node-info and top-receiver panel to 300 Thomas Lamprecht
2024-02-26 16:28 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240226162853.2519262-4-t.lamprecht@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal