From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>
Cc: Dominik Csapak <d.csapak@proxmox.com>, pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [PATCH pmg-gui v3 0/3] implement and combination and inversion of groups and objects
Date: Thu, 22 Feb 2024 14:51:19 +0100 [thread overview]
Message-ID: <20240222145119.4357fe35@rosa.proxmox.com> (raw)
In-Reply-To: <298be08f-6c2f-4c63-ae1e-f34e7dd6cc53@proxmox.com>
On Thu, 22 Feb 2024 14:26:52 +0100
Thomas Lamprecht <t.lamprecht@proxmox.com> wrote:
> Am 22/02/2024 um 14:19 schrieb Stoiko Ivanov:
> > FWIW: applied it locally, gave it a spin, and verified that the
> > deletion-bug is gone!
> >
> > Thanks for the fast iteration!
>
> Can I assume a T-b and/or R-b from that?
T-b - yes definitely
R-b - my javascript-skills are usually limited to asking Dominik how to do
certain thing in our gui-code - so the value of my review might be limited
- but - yes - it looks good to me
next prev parent reply other threads:[~2024-02-22 13:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 9:14 Dominik Csapak
2024-02-22 9:14 ` [pmg-devel] [PATCH pmg-gui v3 1/3] rules: use tree panel instead of grouping feature of the grid Dominik Csapak
2024-02-22 9:14 ` [pmg-devel] [PATCH pmg-gui v3 2/3] rules/objects: add mode selector dropdown Dominik Csapak
2024-02-22 9:14 ` [pmg-devel] [PATCH pmg-gui v3 3/3] objects: don't reload on match mode change Dominik Csapak
2024-02-22 13:19 ` [pmg-devel] [PATCH pmg-gui v3 0/3] implement and combination and inversion of groups and objects Stoiko Ivanov
2024-02-22 13:26 ` Thomas Lamprecht
2024-02-22 13:51 ` Stoiko Ivanov [this message]
2024-02-22 14:24 ` [pmg-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240222145119.4357fe35@rosa.proxmox.com \
--to=s.ivanov@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.